Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] support for passing custom http client (or axios instance) #131

Open
daisy1754 opened this issue Dec 28, 2022 · 1 comment · May be fixed by #146
Open

[Feature Request] support for passing custom http client (or axios instance) #131

daisy1754 opened this issue Dec 28, 2022 · 1 comment · May be fixed by #146
Assignees
Labels
enhancement New feature or request

Comments

@daisy1754
Copy link

Is your feature request related to a problem? Please describe.
We want to pass custom http client to sdk so we can instrument request latency etc using interceptor code we have across our code base.

Describe the solution you'd like
Ability to pass http client via cosntructor arg to sdk. For instance here is how stripe-node support custom http client
https://github.com/stripe/stripe-node/blob/master/types/lib.d.ts#L73

@daisy1754 daisy1754 added the enhancement New feature or request label Dec 28, 2022
@yarinvak yarinvak linked a pull request Feb 17, 2023 that will close this issue
5 tasks
@alfonso-paella
Copy link

This would allow for the usage of connection pooling, for ex., which would be a very necessary feature for apps handling high throughput applications reliant on Fireblocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants