Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Archive Vault / Wallet *via* API #169

Open
cyrilchapon opened this issue May 10, 2023 · 6 comments
Open

[Feature Request] Archive Vault / Wallet *via* API #169

cyrilchapon opened this issue May 10, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@cyrilchapon
Copy link

In a context where we abstract the wallet creation behind a REST API of our own; we have a use case where we probably should archive the vault account + wallet linked to a user.

I discovered it can be done via the console; but not via API.

Any plans to support it ?

@cyrilchapon cyrilchapon added the enhancement New feature or request label May 10, 2023
@tomerrrrrr
Copy link

Hi @cyrilchapon ! Hiding the vaults from the UI is available via the hiddenOnUI property. https://developers.fireblocks.com/reference/post_vault-accounts-vaultaccountid-hide

@cyrilchapon
Copy link
Author

From my tests, the "hidden" state is different from the archived one

@tomerrrrrr
Copy link

that is correct - we have 2 different things .. hiding , and archiving. You can see the comparison table of these two here - https://support.fireblocks.io/hc/en-us - and basically, if you plan on having more than 50 vault accounts, hiding is probably the better approach, which is why we focused on the hiding experience in our APIs. I would love to hear if you have more questions or benefits for the archiving approach over the hiding approach, that may work better with our APIs, and we can revisit this.

@cyrilchapon
Copy link
Author

cyrilchapon commented Jun 6, 2023

@tomerrrrrr ok thanks.

I would love to hear if you have more questions or benefits for the archiving approach over the hiding approach, that may work better with our APIs, and we can revisit this.

Well they're basically 2 separates use-case IMHO. The "hiding" approach is essentially here not-to-mess-the-ui with many-wallets applications (and I think we will need this eventually); while the "archiving" approach is sort of a "soft-delete" mecanism.

In other words :

  • "Hiding" = "I'm using it, but it's not as crucial to show in the UI"
  • "Archiving" = "I'm not using it anymore, and I don't want to see it — until I really need for special purposes"

@tomerrrrrr
Copy link

That is correct.
We are actually planning a soft-delete, but it will be a bit more grandiose :) will it be OK that I contact you as we progress with this initiative?

@cyrilchapon
Copy link
Author

OFC, my pleasure ☺️
Looking forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants