Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use split_array_ref #3347

Closed
JonathanWoollett-Light opened this issue Jan 2, 2023 · 4 comments
Closed

Use split_array_ref #3347

JonathanWoollett-Light opened this issue Jan 2, 2023 · 4 comments
Labels
Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` Status: Blocked Indicates that an issue or pull request cannot currently be worked on Type: Fix Indicates a fix to existing code

Comments

@JonathanWoollett-Light
Copy link
Contributor

Use <[T; N]>::split_array_ref to improve src/cpuid/src/intel/mod.rs IntelCpuid::default_brand_string.

Blocked on rust-lang/rust#90091
@JonathanWoollett-Light JonathanWoollett-Light added Quality: Improvement Status: Blocked Indicates that an issue or pull request cannot currently be worked on labels Jan 2, 2023
@0xkelvin
Copy link

can i take this @JonathanWoollett-Light

@JonathanWoollett-Light
Copy link
Contributor Author

@0xkelvin This issue cannot be closed or worked on until rust-lang/rust#90091 is closed and <[T; N]>::split_array_ref is stabilized.

@0xkelvin
Copy link

i see

@JonathanWoollett-Light JonathanWoollett-Light added Type: Fix Indicates a fix to existing code Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` and removed Quality: Improvement labels Mar 23, 2023
@roypat
Copy link
Contributor

roypat commented Nov 13, 2024

Hey Jonathan, I've had a look at the default_brand_string function, and I honestly don't see where we could use split_array_ref in it, even if it were stabilized (and actually it seems like split_array_ref got removed altogether in rust-lang/rust#117561).

So I'm closing this for now. Please feel free to reopen if you still think there's a refactor possible in default_brand_string

@roypat roypat closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` Status: Blocked Indicates that an issue or pull request cannot currently be worked on Type: Fix Indicates a fix to existing code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JonathanWoollett-Light @0xkelvin @roypat