Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring functionals #65

Open
rckirby opened this issue Apr 16, 2024 · 0 comments
Open

Refactoring functionals #65

rckirby opened this issue Apr 16, 2024 · 0 comments

Comments

@rckirby
Copy link

rckirby commented Apr 16, 2024

It seems like our code would be a lot cleaner if we could have sets of functionals (the gradient at a point, in Cartesian or tangent/normal coordinates, moments against all polynomials of some degree on a facet, etc).

Advantages:

  • Easier implementation of elements
  • Easier to batch together the evaluations in to_riesz
  • Possibly easier inference of zany mappings in FInAT (hypothesized).

Challenges:

  • This is a pervasive change in functional.py and may require reimplementing all our Ciarlet finite elements
  • We need to make sure not to bump anything indirectly (e.g. code generation of general interpolation operators)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant