Skip to content

Update freshness config #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 25, 2025
Merged

Conversation

fivetran-jamie
Copy link
Contributor

PR Overview

Package version introduced in this PR:
v0.5.0

This PR addresses the following Issue/Feature(s):

Summary of changes:

Updates freshness to align with the new config framework introduced in dbt Core v1.9. Documents how users on older versions of dbt Core will/can interface with freshness

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)

older versions of dbt do not run freshness tests, but there's no error message
image

  • Testing Instructions: Confirm the change addresses the issue(s)
    freshness tests are running on dbt 1.9.5+
    image

  • Focus Areas: Complex logic or queries that need extra attention

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-jamie fivetran-jamie self-assigned this Jun 23, 2025
Copy link
Collaborator

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages.yml Outdated
Comment on lines 2 to 5
# version: [">=0.5.0", "<0.6.0"]
- git: https://github.com/fivetran/dbt_amazon_ads_source.git
revision: feature/update-freshness-config
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to swap

@fivetran-jamie fivetran-jamie merged commit d4f0c5f into main Jun 25, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants