Skip to content

Glow "effect" implementation #2137

Open
@st-pasha

Description

@st-pasha

This thread is about the glow "effect" and the best strategy for applying it. This follows our discussion from PR #2129, moved here for better visibility (as that PR is now merged).

The GlowEffect which is currently in the main branch is useful in some circumstances, but has a number of deficiencies that need to be addressed. Those are:

  • The term "effect" was misapplied here. The phrase "glow effect" is used in graphic design, so we kinda referred to it by the same name. However, in Flame the word "Effect" has a specific meaning: it is an animation that changes over time some property of a component. For example, MoveEffect, OpacityEffect. The "glow effect", however, is static: you add it to an object to make the object glow.

    • These kinds of visual effects we were calling Decorations so far, so perhaps we should consider changing GlowEffect into a GlowDecoration. Of course, this affects not only the name but also how the effect is applied.
    • Of course, you may want to have an actual effect that changes glow over time (say, pulsating glow) -- this may be called GlowDecorationEffect or something like that.
  • The glow effect currently modifies an existing paint, which makes its correct application quite tricky. We should consider a glow effect that adds a glow instead.

  • The glow is kinda weak -- we should investigate the possibility of making it stronger if needed.

This issue is a discussion to collect ideas/observations, and figure out the path forward.

CC: @dipakp2726, @spydon

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions