Skip to content
This repository was archived by the owner on Jun 20, 2025. It is now read-only.

Commit 1862263

Browse files
committed
feat: sim now functions
1 parent 924a65a commit 1862263

File tree

4 files changed

+26
-5
lines changed

4 files changed

+26
-5
lines changed

src/main/java/org/team1540/robot2024/Constants.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,9 +129,9 @@ public static class Elevator {
129129
public static final double KI = 0;
130130
public static final double KD = 0.1;
131131
public static final double KG = 0;
132-
public static final int CRUISE_VELOCITY_MPS = 2;
133-
public static final int MAXIMUM_ACCELERATION_MPS2 = 20;
134-
public static final int JERK_MP3 = 40;
132+
public static final double CRUISE_VELOCITY_MPS = 2;
133+
public static final double MAXIMUM_ACCELERATION_MPS2 = 20;
134+
public static final double JERK_MP3 = 40;
135135
public static final double SPROCKET_CIRCUMFERENCE = .044 * Math.PI;
136136
public static final double MOTOR_ROTS_TO_METERS = GEAR_RATIO * SPROCKET_CIRCUMFERENCE;
137137
public static final double ERROR_TOLERANCE = 0.03;

src/main/java/org/team1540/robot2024/RobotContainer.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,11 @@
1010
import edu.wpi.first.wpilibj2.command.button.CommandXboxController;
1111

1212
import org.littletonrobotics.junction.networktables.LoggedDashboardNumber;
13+
import org.team1540.robot2024.Constants.Elevator.ElevatorState;
1314
import org.team1540.robot2024.commands.FeedForwardCharacterization;
1415
import org.team1540.robot2024.commands.SwerveDriveCommand;
1516
import org.team1540.robot2024.commands.elevator.ElevatorManualCommand;
17+
import org.team1540.robot2024.commands.elevator.ElevatorSetpointCommand;
1618
import org.team1540.robot2024.subsystems.drive.*;
1719
import org.team1540.robot2024.subsystems.elevator.Elevator;
1820
import org.team1540.robot2024.subsystems.elevator.ElevatorIO;
@@ -118,7 +120,9 @@ public RobotContainer() {
118120
*/
119121
private void configureButtonBindings() {
120122
drivetrain.setDefaultCommand(new SwerveDriveCommand(drivetrain, driver));
121-
elevator.setDefaultCommand(new ElevatorManualCommand(elevator, driver));
123+
elevator.setDefaultCommand(new ElevatorManualCommand(elevator, copilot));
124+
copilot.rightBumper().onTrue(new ElevatorSetpointCommand(elevator, ElevatorState.TOP));
125+
copilot.leftBumper().onTrue(new ElevatorSetpointCommand(elevator, ElevatorState.BOTTOM));
122126
driver.x().onTrue(Commands.runOnce(drivetrain::stopWithX, drivetrain));
123127
driver.b().onTrue(
124128
Commands.runOnce(

src/main/java/org/team1540/robot2024/commands/elevator/ElevatorManualCommand.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public ElevatorManualCommand(Elevator elevator, CommandXboxController copilot) {
2020
@Override
2121
public void execute() {
2222
// elevator.setVoltage(copilot.getRightTriggerAxis() - copilot.getLeftTriggerAxis() + Constants.Elevator.KG);
23-
elevator.goToSetpoint(elevator.getSetpoint() + Constants.Elevator.CRUISE_VELOCITY_MPS*2/100*(copilot.getRightTriggerAxis()-copilot.getLeftTriggerAxis()));
23+
elevator.goToSetpoint(elevator.getSetpoint() + Constants.Elevator.CRUISE_VELOCITY_MPS/50.0*(copilot.getRightTriggerAxis()-copilot.getLeftTriggerAxis()));
2424
}
2525

2626
@Override

src/main/java/org/team1540/robot2024/subsystems/elevator/Elevator.java

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,18 @@
11
package org.team1540.robot2024.subsystems.elevator;
22

33
import edu.wpi.first.math.MathUtil;
4+
5+
import org.littletonrobotics.junction.AutoLogOutput;
46
import org.littletonrobotics.junction.Logger;
57

68
import edu.wpi.first.wpilibj2.command.SubsystemBase;
9+
10+
import org.team1540.robot2024.Constants;
711
import org.team1540.robot2024.util.MechanismVisualiser;
812
import org.team1540.robot2024.util.math.AverageFilter;
913

14+
import com.ctre.phoenix6.Utils;
15+
1016
import static org.team1540.robot2024.Constants.Elevator.*;
1117

1218
public class Elevator extends SubsystemBase {
@@ -27,9 +33,17 @@ public void periodic(){
2733
MechanismVisualiser.setElevatorPosition(elevatorInputs.positionMeters);
2834

2935
elevatorPositionFilter.add(elevatorInputs.positionMeters);
36+
37+
// if (elevatorInputs.lowerLimit) {
38+
// setpointMeters = Constants.Elevator.ELEVATOR_MINIMUM_HEIGHT;
39+
// }
40+
// else if (elevatorInputs.upperLimit) {
41+
// setpointMeters = Constants.Elevator.ELEVATOR_MAX_HEIGHT;
42+
// }
3043
}
3144

3245
public void goToSetpoint(double newSetpointMeters) {
46+
newSetpointMeters = MathUtil.clamp(newSetpointMeters, Constants.Elevator.ELEVATOR_MINIMUM_HEIGHT, Constants.Elevator.ELEVATOR_MAX_HEIGHT);
3347
setpointMeters = newSetpointMeters;
3448
elevatorIO.setPositionMeters(setpointMeters);
3549

@@ -48,7 +62,10 @@ public void stop() {
4862
elevatorIO.setVoltage(0.0);
4963
}
5064

65+
@AutoLogOutput
5166
public double getSetpoint() {
5267
return setpointMeters;
5368
}
69+
70+
5471
}

0 commit comments

Comments
 (0)