Skip to content

3.x & 4.x no longer commit dist or dist-typings when gitignored #15

@luceos

Description

@luceos

This might be a problem on my end, but the workflows since version 3 no longer commit the dist or dist-typings directories when they are gitignored.

This is caused by the underlying check in simple-git in the isClean method, it does not include any gitignored files, see: https://github.com/steveukx/git-js/blob/34c5eba49044018f4caea67a3a4a30b1ec69c3f1/simple-git/typings/response.d.ts#L332-L339

Previous logic, with action build 1 and 2, existed to force add dist and dist-typings. We did this so that merge conflicts would not be an issue during merging processes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions