[backport] ci: add LOAD_IMAGES_INTO_CLUSTER variable to control image loading behavior (#911) (#913)

Author: mergify[bot]

.github/workflows/e2e.yml

@@ -42,6 +42,7 @@ env:
   FSM_CLI_ARTIFACTS_NAME: ${{ vars.FSM_CLI_ARTIFACTS_NAME || 'fsm-cli' }}
   CTR_REGISTRY: ${{ vars.CI_CTR_REGISTRY || 'localhost:5000' }}
   CTR_TAG: ${{ github.sha }}
+  LOAD_IMAGES_INTO_CLUSTER: ${{ vars.LOAD_IMAGES_INTO_CLUSTER || 'false' }}
 
 permissions:
   contents: read
@@ -104,11 +105,11 @@ jobs:
           chmod a+x ./bin/fsm
           ls -l ./bin/fsm
       - name: Create k3d managed local registry
-        if: ${{ env.INCREASE_K3D_CIDR_RANGE != 'true' }}
+        if: ${{ env.LOAD_IMAGES_INTO_CLUSTER != 'true' }}
         run: |
           k3d registry create registry.localhost --port localhost:5000
       - name: Push images to local registry
-        if: ${{ env.INCREASE_K3D_CIDR_RANGE != 'true' }}
+        if: ${{ env.LOAD_IMAGES_INTO_CLUSTER != 'true' }}
         run: |
           docker image list --format "{{.Repository}}:{{.Tag}}" | grep "^localhost" | xargs --no-run-if-empty -L 1 docker push
       - name: Run tests
@@ -137,6 +138,7 @@ jobs:
         with:
           name: ${{ env.ARTIFACT_NAME }}
           path: /tmp/test**/*
+          if-no-files-found: ignore
       - name: Check continue tests
         if: ${{ steps.test.conclusion != 'skipped' && steps.test.outcome == 'failure'}}
         run: exit 1

tests/e2e/e2e_retry_policy_test.go

@@ -53,7 +53,7 @@ var _ = FSMDescribe("Test Retry Policy",
 						SimplePodAppDef{
 							PodName:   server,
 							Namespace: server,
-							Image:     "mccutchen/go-httpbin",
+							Image:     "ghcr.io/mccutchen/go-httpbin",
 							Ports:     []int{80},
 							OS:        Td.ClusterOS,
 							Command:   []string{"/bin/go-httpbin"},