Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leave native folder icon #10

Open
Ygarr opened this issue Feb 1, 2021 · 5 comments
Open

Leave native folder icon #10

Ygarr opened this issue Feb 1, 2021 · 5 comments

Comments

@Ygarr
Copy link

Ygarr commented Feb 1, 2021

May be leave original folder icon theme but with pictures preview(e.g. KDE-style)

@flozz
Copy link
Owner

flozz commented Feb 2, 2021

Hello,

Did you mean something like this?

image

This will not be implemented in Cover Thumbnailer : It is too complicated to have a good-looking result in Nautilus for that.

There was already an old discussion about this on Launchpad → https://blueprints.launchpad.net/cover-thumbnailer/+spec/folder-icons-instead-of-cd-covers

:)

@Ygarr
Copy link
Author

Ygarr commented Feb 3, 2021

Yes, pity.
But as a case not Nautilus, but consider mate-caja or cinnamon-nemo...

@flozz
Copy link
Owner

flozz commented Feb 4, 2021

Caja is a fork of Nautilus 2.x and Nemo is a fork of Nautilus 3.x... So it would not be better... ^^'

Also, please note that Cover Thumbnailer is no more developed, it is in "maintenance" mode, so I will not work on new feature anymore, only bug fix, (more info in this blog post).

@eMBee
Copy link

eMBee commented Jan 20, 2022

i am working on this:

https://gitlab.com/eMBee/cover-thumbnailer

yes, it doesn't look very good, but the key for me is to convey information, and the folder icon is critical for that.
right now the folder icon is hardcoded, but ideally i'd like to somehow figure out which folder icon the filemanager actually uses, and use that instead.

@eMBee
Copy link

eMBee commented Jan 21, 2022

looking further into getting the right theme.
finding the themes folder icon is easy enough:

from gi.repository import Gtk
icon_theme = Gtk.IconTheme.get_default()
icon_info = icon_theme.lookup_icon("folder", 256, 0)
icon_file = icon_info.get_filename()
icon_pixbuf = icon_theme.load_icon("folder", 256, 0)
icon_image = Image.fromstring("RGBA",(icon_pixbuf.get_width(),icon_pixbuf.get_height()),icon_pixbuf.get_pixels())

but not all themes will look good, and the icons need some tailoring which may require custom code per theme.
maybe it is better to optimize the default theme first.

then additional themes can be added if there is demand and contributions. and for unsupported themes the default would be used, or a custom theme selector could be added to the gui if someone is willing to contribute.

here are some examples of how it looks right now. i think it doesn't look to bad actually. perhaps it can be improved by removing the round corners to make the shadow less jarring.

cover-thumbnailer-example-4
cover-thumbnailer-example-3
cover-thumbnailer-example-2
cover-thumbnailer-example-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants