Fluent Bit v4.0.1 in Buildroot?? - Need support!

[ThomasDevoogdt]

Hi, I would like to bump the fluent-bit package in buildroot, see https://github.com/buildroot/buildroot/tree/master/package/fluent-bit.

Currently, a lot of custom patches are taken along to get things build. I would like to upstream as much as possible. I opened a bunch of pull requests to get this done, but I see little to no movement on all of them. Please, help me out to get these landed. It would make my life easier if these are just getting proper review and attention. And it would make fluent-bit available in a widely used platform.

Here is an (ordered list of importance) of pull requests that I really want to see landed in e.g. v4.0.1:

• lib: kafka: fix cross compile error #9600
• build: use the system provided libmsgpack and libsqlite3 if found #9572
• lib: luajit-cmake: CMakeLists.txt: do not require a CXX compiler #9815
• lib: nghttp2: CMakeLists.txt: do not require a CXX compiler #9816
• lib: kafka: CMakeLists.txt: do not require a CXX compiler  #9817
• workflows: add sanity check for toolchains w/ CXX support #9277

Here is a list of issues I still don't got any answer on:

• Building without FLB_SQLDB (sqlite3) support completely broken. #9757

@edsiper

[leonardo-albertovich]

While I support the idea I think we need to be cautious about the approach. Modifying dependency provided files means someone would have to keep merging those patches when we update the libraries or a regression could be caused (which wouldn't be caught by our tests).

[leonardo-albertovich]

Maybe we should include those patches in a way that allows us to apply them on top of the original files as part of the build process?

[ThomasDevoogdt]

Maybe we should include those patches in a way that allows us to apply them on top of the original files as part of the build process?

These patches in buildroot have all a reference to a pull request on this repo. Some are indeed merged, but others not. I'm just reaching out here to have a look to the patches which are not yet merged. I summarized them above. I also try to upstream patches further than only this repo, e.g. PR #9816 fixes something in nghttp2, but the actual fix is already upstreamed, I'm just waiting for review.

[leonardo-albertovich]

I understand what you mean but I brought up the issue to try to steer things in the right direction to avoid future problems regardless of there are pre existing changes.