Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test to validate .ci.yaml builds that use runIf: do not omit DEPS and engine/** #160707

Open
matanlurey opened this issue Dec 21, 2024 · 1 comment · May be fixed by flutter/cocoon#4137
Open

Add a test to validate .ci.yaml builds that use runIf: do not omit DEPS and engine/** #160707

matanlurey opened this issue Dec 21, 2024 · 1 comment · May be fixed by flutter/cocoon#4137
Assignees
@matanlurey
Labels
c: tech-debt Technical debt, code quality, testing, etc. monorepo monorepo related issues (infra, process, workflow) P1 High-priority issues at the top of the work list team-infra Owned by Infrastructure team

Comments

@matanlurey
Copy link
Contributor

In other words, automatically check and enforce what I did in #160706.
@matanlurey matanlurey added team-infra Owned by Infrastructure team P1 High-priority issues at the top of the work list c: tech-debt Technical debt, code quality, testing, etc. monorepo monorepo related issues (infra, process, workflow) labels Dec 21, 2024
@matanlurey
Copy link
Contributor Author

Oh, dur, I guess this just needs to be updated:

https://github.com/flutter/cocoon/blob/dcc99fad7e0a49d5856a15fa4990b1633689f839/app_dart/lib/src/model/ci_yaml/ci_yaml.dart#L396-L417

@matanlurey matanlurey self-assigned this Dec 21, 2024
@matanlurey matanlurey linked a pull request Dec 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matanlurey matanlurey

Labels
c: tech-debt Technical debt, code quality, testing, etc. monorepo monorepo related issues (infra, process, workflow) P1 High-priority issues at the top of the work list team-infra Owned by Infrastructure team
Projects
Infra Ticket Queue
Status: New
Monorepo
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix .ci.yaml validation for Fusion (the monorepo) matanlurey/cocoon
1 participant
@matanlurey