Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Impeller] MoltenVK and triangle fans usage in Vulkan needs workarounds. #158024

Closed
chinmaygarde opened this issue Nov 1, 2024 · 1 comment · Fixed by flutter/engine#56321
Closed

[Impeller] MoltenVK and triangle fans usage in Vulkan needs workarounds. #158024

chinmaygarde opened this issue Nov 1, 2024 · 1 comment · Fixed by flutter/engine#56321
Labels
e: impeller Impeller rendering backend issues and features requests P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@chinmaygarde
Copy link
Member

Super low priority. On the Mac, there must be a cap check for the triangle primitive topology when the portability subset extension is enabled (which SwiftShader wont enable by Molten will). Otherwise, there will be rendering errors.

--- Vulkan Debug Report  ----------------------------------------
|                Severity: Error
|                    Type: { Validation }
|                 ID Name: VUID-VkPipelineInputAssemblyStateCreateInfo-triangleFans-04452
|               ID Number: 1316858618
|       Queue Breadcrumbs: [NONE]
|  CMD Buffer Breadcrumbs: [NONE]
|                 Trigger: Validation Error: [ VUID-VkPipelineInputAssemblyStateCreateInfo-triangleFans-04452 ] | MessageID = 0x4e7daafa | vkCreateGraphicsPipelines(): pCreateInfos[0] (portability error): VK_PRIMITIVE_TOPOLOGY_TRIANGLE_FAN is not supported. The Vulkan spec states: If the VK_KHR_portability_subset extension is enabled, and VkPhysicalDevicePortabilitySubsetFeaturesKHR::triangleFans is VK_FALSE, topology must not be VK_PRIMITIVE_TOPOLOGY_TRIANGLE_FAN (https://vulkan.lunarg.com/doc/view/1.3.280.0/mac/1.3-extensions/vkspec.html#VUID-VkPipelineInputAssemblyStateCreateInfo-triangleFans-04452)
-----------------------------------------------------------------
@chinmaygarde chinmaygarde added e: impeller Impeller rendering backend issues and features requests team-engine Owned by Engine team labels Nov 1, 2024
@jonahwilliams
Copy link
Member

Lets just ifdef it out on macOS?

chinmaygarde added a commit to chinmaygarde/flutter_engine that referenced this issue Nov 1, 2024
@chinmaygarde
[Impeller] Avoid errors due to triangle fans usage on Molten.
44dbe3d 
Added the test case for flutter/flutter#157885 to the corpus but Jonah fixed it in flutter#56310.

Fixes flutter/flutter#158024 which is more of an inconvenience on macOS.
@chinmaygarde chinmaygarde mentioned this issue Nov 1, 2024
Merged
@jonahwilliams jonahwilliams added P2 Important issues not at the top of the work list triaged-engine Triaged by Engine team labels Nov 4, 2024
chinmaygarde added a commit to chinmaygarde/flutter_engine that referenced this issue Nov 4, 2024
@chinmaygarde
[Impeller] Avoid errors due to triangle fans usage on Molten.
c52f878 
Added the test case for flutter/flutter#157885 to the corpus but Jonah fixed it in flutter#56310.

Fixes flutter/flutter#158024 which is more of an inconvenience on macOS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
e: impeller Impeller rendering backend issues and features requests P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Impeller] Avoid errors due to triangle fans usage on Molten. chinmaygarde/flutter_engine
2 participants
@chinmaygarde @jonahwilliams