Skip to content

Commit 9716995

Browse files
committed
apply review suggestions
1 parent 3a5eb9c commit 9716995

File tree

3 files changed

+33
-35
lines changed

3 files changed

+33
-35
lines changed

site/lib/src/layouts/tutorial_layout.dart

Lines changed: 31 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -15,40 +15,38 @@ class TutorialLayout extends DocLayout {
1515

1616
@override
1717
Component buildBody(Page page, Component child) {
18-
page.apply(
19-
data: {
20-
'page': {
21-
'showBanner': false,
22-
//TODO(schultek): Extract the real pages in some way.
23-
'navigationEntries': [
24-
{'type': 'divider', 'title': 'Introdution to Flutter UI'},
25-
{'title': 'Create a Flutter app', 'path': '/fwe0'},
26-
{'title': 'Widget fundamentals', 'path': '/fwe1'},
27-
{'title': 'Layout widgets on a screen', 'path': '/fwe2'},
28-
{'title': 'FWE Testing Page', 'path': '/fwe'},
29-
{'title': 'Devtools', 'path': '/fwe3'},
30-
{'title': 'Handle user input', 'path': '/fwe4'},
31-
{'type': 'divider', 'title': 'State in Flutter apps'},
32-
{'title': 'Set up a new project', 'path': '/fwe5'},
33-
{'title': 'Make Http Requests', 'path': '/fwe6'},
34-
{
35-
'title': 'Use ChangeNotifier to update app state',
36-
'path': '/fwe7',
37-
},
38-
{
39-
'title': 'Use ListenableBuilder to update app UI',
40-
'path': '/fwe8',
41-
},
42-
{'type': 'divider', 'title': 'Flutter UI 102'},
43-
{'title': 'Set up your project', 'path': '/fwe9'},
44-
{'title': 'LayoutBuilder and adaptive layouts', 'path': '/fwe10'},
45-
{'title': 'Scrolling and slivers', 'path': '/fwe11'},
46-
{'title': 'Stack based navigation', 'path': '/fwe12'},
47-
],
18+
//TODO(schultek): Extract the real pages in some way.
19+
const navigationEntries = [
20+
{'type': 'divider', 'title': 'Introdution to Flutter UI'},
21+
{'title': 'Create a Flutter app', 'path': '/fwe0'},
22+
{'title': 'Widget fundamentals', 'path': '/fwe1'},
23+
{'title': 'Layout widgets on a screen', 'path': '/fwe2'},
24+
{'title': 'FWE Testing Page', 'path': '/fwe'},
25+
{'title': 'Devtools', 'path': '/fwe3'},
26+
{'title': 'Handle user input', 'path': '/fwe4'},
27+
{'type': 'divider', 'title': 'State in Flutter apps'},
28+
{'title': 'Set up a new project', 'path': '/fwe5'},
29+
{'title': 'Make Http Requests', 'path': '/fwe6'},
30+
{'title': 'Use ChangeNotifier to update app state', 'path': '/fwe7'},
31+
{'title': 'Use ListenableBuilder to update app UI', 'path': '/fwe8'},
32+
{'type': 'divider', 'title': 'Flutter UI 102'},
33+
{'title': 'Set up your project', 'path': '/fwe9'},
34+
{'title': 'LayoutBuilder and adaptive layouts', 'path': '/fwe10'},
35+
{'title': 'Scrolling and slivers', 'path': '/fwe11'},
36+
{'title': 'Stack based navigation', 'path': '/fwe12'},
37+
];
38+
39+
return super.buildBody(
40+
page..apply(
41+
data: {
42+
'page': {
43+
'showBanner': false,
44+
'navigationEntries': navigationEntries,
45+
},
46+
'sidenav': null,
4847
},
49-
'sidenav': null,
50-
},
48+
),
49+
child,
5150
);
52-
return super.buildBody(page, child);
5351
}
5452
}

site/lib/src/models/page_navigation_model.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ final class PageNavigationData {
9797
final List<PageNavigationEntry> pageEntries;
9898
}
9999

100-
class TocNavigationData {
100+
final class TocNavigationData {
101101
TocNavigationData(this.topLevelEntries);
102102

103103
final List<TocNavigationEntry> topLevelEntries;

site/lib/src/style_hash.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
// dart format off
33

44
/// The generated hash of the `main.css` file.
5-
const generatedStylesHash = 'sb87ATyGGABK';
5+
const generatedStylesHash = 'CvVP5TpgA9WG';

0 commit comments

Comments
 (0)