popScopesTill broken in version 8

[kuhnroyal]

Hello @escamoteur

The changes in commit 7d2d4bb lead to popScopeTill(inclusive: true) always popping all scopes until the base scope. The while loop exit condition does not trigger when inclusive == true.

[kuhnroyal]

I added tests in #385 for now

[escamoteur]

Could you determine where the problem is? Am 23. Okt. 2024, 16:09 +0100 schrieb Peter Leibiger ***@***.***>:

…

I added tests in #385 for now — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

[kuhnroyal]

Yea, I think I fixed it.

while (hasScope(scopeName) && inclusive
        ? (poppedScopeName != scopeName)
        : (nextScopeToPop.name != scopeName))

This lead to the else branch running even if hasScope returned false.

Additionally I found a secondary problem if the passed scopeName is the top scope and inclusive == false which would always have popped the first scope because of the used do() while loop.

Changes are on the same PR.

[kuhnroyal]

Fixed by #385

[kuhnroyal]

@escamoteur Can you please cut a release when you get a chance, thanks!

[escamoteur]

Sure, I was hoping to include the latest 2 PRs one is already merged. If the other doesn't come in this afternoon I will publish it anyway Am 28. Okt. 2024, 12:28 +0000 schrieb Peter Leibiger ***@***.***>:

…

@escamoteur Can you please cut a release when you get a chance, thanks! — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

[escamoteur]

done Nachricht von ***@***.*** am Oct 28, 2024, 1:30 PM +0100:

…

Sure, I was hoping to include the latest 2 PRs one is already merged. If the other doesn't come in this afternoon I will publish it anyway Am 28. Okt. 2024, 12:28 +0000 schrieb Peter Leibiger ***@***.***>: > @escamoteur Can you please cut a release when you get a chance, thanks! > — > Reply to this email directly, view it on GitHub, or unsubscribe. > You are receiving this because you were mentioned.Message ID: ***@***.***>

[kuhnroyal]

Thanks a lot!