chore: improve tests

Author: npv12

pkg/metrics/providers/signoz.go

@@ -17,6 +17,7 @@ limitations under the License.
 package providers
 
 import (
+	"bytes"
 	"context"
 	"crypto/tls"
 	"encoding/json"
@@ -26,7 +27,6 @@ import (
 	"net/http"
 	"net/url"
 	"path"
-	"strings"
 	"time"
 
 	flaggerv1 "github.com/fluxcd/flagger/pkg/apis/flagger/v1beta1"
@@ -136,7 +136,6 @@ func (p *SignozProvider) RunQuery(query string) (float64, error) {
 	}
 	q["start"] = start
 	q["end"] = now
-	q["requestType"] = "time_series"
 
 	payload, err := json.Marshal(q)
 	if err != nil {
@@ -151,7 +150,7 @@ func (p *SignozProvider) RunQuery(query string) (float64, error) {
 	u.Path = path.Join(p.url.Path, u.Path)
 	u = p.url.ResolveReference(u)
 
-	req, err := http.NewRequest("POST", u.String(), io.NopCloser(strings.NewReader(string(payload))))
+	req, err := http.NewRequest("POST", u.String(), bytes.NewReader(payload))
 	if err != nil {
 		return 0, fmt.Errorf("http.NewRequest failed: %w", err)
 	}

pkg/metrics/providers/signoz_test.go

@@ -177,7 +177,6 @@ func TestSignozProvider_RunQuery(t *testing.T) {
 		queryResult string
 	}{
 		{name: "multiple series", queryResult: `{"status":"success","data":{"data":{"results":[{"queryName":"A","aggregations":[{"series":[{"values":[{"timestamp":1714404069294,"value":1}]},{"values":[{"timestamp":1714404069294,"value":2}]}]}]}]}}}`},
-		{name: "multiple series", queryResult: `{"status":"success","data":{"data":{"results":[{"queryName":"A","aggregations":[{"series":[{"values":[{"timestamp":1714404069294,"value":1}]},{"values":[{"timestamp":1714404069294,"value":2}]}]}]}]}}}`},
 	}
 
 	for _, tt := range multipleResultTests {
@@ -292,3 +291,54 @@ func TestSignozProvider_RunQueryWithProviderHeaders(t *testing.T) {
 		assert.Equal(t, float64(100), val)
 	})
 }
+
+func TestSignozProvider_RunQueryWithPartialValues(t *testing.T) {
+	t.Run("filters partial values and returns last non-partial value", func(t *testing.T) {
+		ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+			// Response with multiple values including partial ones
+			json := `{"status":"success","data":{"type":"time_series","data":{"results":[{"queryName":"A","aggregations":[{"index":0,"alias":"","series":[{"labels":[],"values":[{"timestamp":1742602572000,"value":50},{"timestamp":1742602573000,"value":75},{"timestamp":1742602574000,"value":100,"partial":true},{"timestamp":1742602575000,"value":200,"partial":true}]}]}]}]}}}`
+			w.Write([]byte(json))
+		}))
+		defer ts.Close()
+
+		clients := signozFake()
+
+		template, err := clients.flaggerClient.FlaggerV1beta1().MetricTemplates("default").Get(context.TODO(), "signoz", metav1.GetOptions{})
+		require.NoError(t, err)
+		template.Spec.Provider.Address = ts.URL
+
+		secret, err := clients.kubeClient.CoreV1().Secrets("default").Get(context.TODO(), "signoz", metav1.GetOptions{})
+		require.NoError(t, err)
+
+		sp, err := NewSignozProvider("1m", template.Spec.Provider, secret.Data)
+		require.NoError(t, err)
+
+		val, err := sp.RunQuery(template.Spec.Query)
+		require.NoError(t, err)
+		// Should return 75, the last non-partial value, not 200
+		assert.Equal(t, float64(75), val)
+	})
+
+	t.Run("returns error when all values are partial", func(t *testing.T) {
+		ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+			json := `{"status":"success","data":{"type":"time_series","data":{"results":[{"queryName":"A","aggregations":[{"index":0,"alias":"","series":[{"labels":[],"values":[{"timestamp":1742602572000,"value":50,"partial":true},{"timestamp":1742602573000,"value":75,"partial":true}]}]}]}]}}}`
+			w.Write([]byte(json))
+		}))
+		defer ts.Close()
+
+		clients := signozFake()
+
+		template, err := clients.flaggerClient.FlaggerV1beta1().MetricTemplates("default").Get(context.TODO(), "signoz", metav1.GetOptions{})
+		require.NoError(t, err)
+		template.Spec.Provider.Address = ts.URL
+
+		secret, err := clients.kubeClient.CoreV1().Secrets("default").Get(context.TODO(), "signoz", metav1.GetOptions{})
+		require.NoError(t, err)
+
+		sp, err := NewSignozProvider("1m", template.Spec.Provider, secret.Data)
+		require.NoError(t, err)
+
+		_, err = sp.RunQuery(template.Spec.Query)
+		require.True(t, errors.Is(err, ErrNoValuesFound))
+	})
+}