Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli): improve flag help descriptions to show allowed values instead of type names #5067

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

chore(cli): improve flag help descriptions to show allowed values instead of type names #5067

wants to merge 5 commits into from

Conversation

h3nryc0ding
Copy link
Contributor

@h3nryc0ding h3nryc0ding commented Nov 10, 2024 •
edited by stefanprodan
Loading

Closes #5066

@h3nryc0ding h3nryc0ding force-pushed the fix/flags-allowed-values branch from 4acb77b to 64739b4 Compare November 10, 2024 03:23
@h3nryc0ding h3nryc0ding force-pushed the fix/flags-allowed-values branch from a655858 to 4404634 Compare November 13, 2024 00:32
h3nryc0ding
h3nryc0ding commented Nov 13, 2024
View reviewed changes
Copy link
Contributor Author

@h3nryc0ding h3nryc0ding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found some places where I'm unsure if shortening the descriptions, as done elsewhere, is a good idea. I'd really appreciate any feedback on this.

internal/flags/helm_chart_source.go Outdated Show resolved Hide resolved
internal/flags/kustomization_source.go Outdated Show resolved Hide resolved
internal/flags/local_helm_chart_source.go Outdated Show resolved Hide resolved
@h3nryc0ding h3nryc0ding marked this pull request as ready for review November 13, 2024 00:37
@h3nryc0ding h3nryc0ding changed the title Improve flag help descriptions to show allowed values instead of type names chore(cli): improve flag help descriptions to show allowed values instead of type names Nov 13, 2024
@stefanprodan stefanprodan added the area/ux In pursuit of a delightful user experience label Nov 13, 2024
@h3nryc0ding
implement recommended changes
8093ad7 
Signed-off-by: h3nryc0ding <[email protected]>
@h3nryc0ding
minimize diff
92e5884 
Signed-off-by: h3nryc0ding <[email protected]>
@h3nryc0ding h3nryc0ding force-pushed the fix/flags-allowed-values branch from ee59d5f to 92e5884 Compare December 23, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan left review comments

@darkowlzz darkowlzz Awaiting requested review from darkowlzz

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/ux In pursuit of a delightful user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change flags with fixed allowed values to show the actual values
3 participants
@h3nryc0ding @darkowlzz @stefanprodan