Feature request: configurable safeguards against misconfiguration

[imax9000]

I have accidentally misconfigured FluxInstance to point to an empty directory, and Flux gleefully proceeded to delete everything it was managing before :)

It would be nice to have some basic configurable sanity checks to require manual confirmation in a situation where all or almost all of the inventory is about to be deleted.

---

Additional considerations:

• It should probably apply only when the managing resource itself is not getting deleted. E.g., if the user deletes Kustomization or HelmRelease - they probably intended for the relevant resources to be deleted too. OTOH, if Kustomization suddenly evaluates to just 1 object instead of 100 - that is very likely to be a mistake.
• There are obviously cases when the user actually intends to delete a lot of things at once, and an extra step of manual approval could be annoying. To improve UX in that situation it could be useful to signal upfront that the decrease in object count is expected (e.g., in a commit message or OCI container annotation)

[chrede88]

I'll point you to a nice tool you can integrate into your CI pipeline (or use locally on CLI): https://github.com/allenporter/flux-local
The diff functionality is very handy in these situations. Here is an example of how I use it: https://github.com/chrede88/home-ops/blob/main/.github/workflows/flux-local.yaml#L64

[imax9000]

Thanks! I'm already running dyff against previous revision, and was wondering if anyone has made something to simulate the effect of HelmRelease and Kustomization objects.

That said, it wouldn't help in the particular instance I mentioned above: I've changed the 'path' field to a subdir in the FluxInstance object which is not managed by Flux.

[chrede88]

I guess that depends on how you setup your git repo. FluxInstance is tracked by the kustomizeController in my repo, e.g. see this PR: chrede88/home-ops#889

[imax9000]

It indeed depends, and having FluxInstance managed externally is a perfectly valid use case too :)