Kustomize and Source Controllers did not requeue some objects upon reconciliation errors

[itsme-ben]

Describe the bug

• Kustomize-controller has stopped reconciling / tracking a kustomize object upon a reconciliation error (fail to update condition.status) for that object.
• Source-controller has dropped a gitrepository object from the queue due to a proxy error

In both cases
The object has spec.interval: 10m - however upon reconciliation error, we don't see the controller attempt to reconcile at all, until the controller restarts or a manual trigger (flux reconcile kustomization ...).

We also don't see any logs after the controller stops reconciling the failed object. We suspect the object was not requeued.

Steps to reproduce

Unsure how to reproduce the error.
We are running flux-operator v0.23.0
Controllers are on v2.6.2

Expected behavior

Flux controllers to continue to requeue and reconcile kustomize or gitrepo objects

Screenshots and recordings

No response

OS / Distro

linux

Flux version

v2.6.4

Flux check

► checking prerequisites
✔ Kubernetes 1.33.4-gke.1245000 >=1.31.0-0
► checking version in cluster
✔ distribution: flux-v2.6.2
✔ bootstrapped: false
► checking controllers
✔ helm-controller: deployment ready
► /controlplaneio-fluxcd/distroless/helm-controller:v1.3.0
✔ kustomize-controller: deployment ready
► /controlplaneio-fluxcd/distroless/kustomize-controller:v1.6.0
✔ notification-controller: deployment ready
► /controlplaneio-fluxcd/distroless/notification-controller:v1.6.0
✔ source-controller: deployment ready
► /controlplaneio-fluxcd/distroless/source-controller:v1.6.1
► checking crds
✔ alerts.notification.toolkit.fluxcd.io/v1beta3
✔ buckets.source.toolkit.fluxcd.io/v1
✔ gitrepositories.source.toolkit.fluxcd.io/v1
✔ helmcharts.source.toolkit.fluxcd.io/v1
✔ helmreleases.helm.toolkit.fluxcd.io/v2
✔ helmrepositories.source.toolkit.fluxcd.io/v1
✔ kustomizations.kustomize.toolkit.fluxcd.io/v1
✔ ocirepositories.source.toolkit.fluxcd.io/v1
✔ providers.notification.toolkit.fluxcd.io/v1beta3
✔ receivers.notification.toolkit.fluxcd.io/v1
✔ all checks passed

Git provider

No response

Container Registry provider

No response

Additional context

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[stefanprodan]

Any type of error will result in a requeue https://github.com/fluxcd/kustomize-controller/blob/a8c7cc16be6061ceee5aa01bc8b1ee10b43a6057/internal/controller/kustomization_controller.go#L283

I suggest adding Kustomization.spec.retryInterval to speed up the retries.