adding printing diff functionality in flux diff artifact #4138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sanskar Bhushan <[email protected]>
hiddeco
reviewed
Aug 17, 2023
Comment on lines
+167
to
+181
| tarReader := tar.NewReader(layerContent) | ||
| for { | ||
| _, err := tarReader.Next() | ||
| if err == io.EOF { | ||
| break | ||
| } | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to read tar header: %w", err) | ||
| } | ||
|
|
||
| // Read the file contents and write them to the buffer | ||
| if _, err := io.Copy(&contentsBuffer, tarReader); err != nil { | ||
| return nil, fmt.Errorf("failed to read tar entry contents: %w", err) | ||
| } | ||
| } |
There was a problem hiding this comment.
Instead of this looking at just file contents, I think it would be much better if path data would be taken into account (which also can be done for local directories, as they are expected to have the same structure as a decompressed tar).
This way, not only differences in file content would be observed. But also things being moved (or swapped) from file A -> B, files changing from path, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3839
cc: @hiddeco @makkes @somtochiama
WIP. Please take a look. For the time being I have added a verbose flag for the functionallity to keep it backward compatible in terms of testing, but it can be removed as other diff commands also simply print the diff and thus it makes sense. I will be adding the test cases soon. Let me know what should be the case.