From 695828ddc139daed6fd7770a2099d02ff9f4bfa6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lucas=20K=C3=A4ldstr=C3=B6m?= Date: Thu, 13 Aug 2020 18:20:49 +0300 Subject: [PATCH] Review feedback --- .golangci.yml | 2 +- bitbucket/doc.go | 2 +- github/resource_repository.go | 2 +- gitlab/doc.go | 2 +- gitprovider/gitprovider.go | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index 4db6889e..59053504 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -46,7 +46,7 @@ linters: # - godox don't error although there are TODOs in the code - funlen - whitespace - # - wsl allow "non-ideomatic" whitespace formattings for now + # - wsl allow "non-idiomatic" whitespace formattings for now - goprintffuncname - gomnd - goerr113 diff --git a/bitbucket/doc.go b/bitbucket/doc.go index cb08392e..68545977 100644 --- a/bitbucket/doc.go +++ b/bitbucket/doc.go @@ -17,6 +17,6 @@ limitations under the License. package bitbucket import ( - // Dummy import until we have the implementation ready. + // TODO: Dummy import until we have the implementation ready. _ "github.com/ktrysmt/go-bitbucket" ) diff --git a/github/resource_repository.go b/github/resource_repository.go index e4e83a36..2f6787ae 100644 --- a/github/resource_repository.go +++ b/github/resource_repository.go @@ -136,7 +136,7 @@ func (r *userRepository) Reconcile(ctx context.Context) (bool, error) { return true, r.Update(ctx) } -// Delete deletes the current resource irreversible. +// Delete deletes the current resource irreversibly. // // ErrNotFound is returned if the resource doesn't exist anymore. func (r *userRepository) Delete(ctx context.Context) error { diff --git a/gitlab/doc.go b/gitlab/doc.go index 8d732db3..d7df82ab 100644 --- a/gitlab/doc.go +++ b/gitlab/doc.go @@ -17,6 +17,6 @@ limitations under the License. package gitlab import ( - // Dummy import until we have the implementation ready. + // TODO: Dummy import until we have the implementation ready. _ "github.com/xanzy/go-gitlab" ) diff --git a/gitprovider/gitprovider.go b/gitprovider/gitprovider.go index 54e315e6..84729773 100644 --- a/gitprovider/gitprovider.go +++ b/gitprovider/gitprovider.go @@ -66,7 +66,7 @@ type Updatable interface { // Deletable is an interface which all objects that can be deleted // using the Client implement. type Deletable interface { - // Delete deletes the current resource irreversible. + // Delete deletes the current resource irreversibly. // // ErrNotFound is returned if the resource doesn't exist anymore. Delete(ctx context.Context) error