queue immediate reconciliation on kustomization dependency

Signed-off-by: Daniele Fognini <[email protected]>

Author: fogninid

internal/controller/dependency_predicate.go

@@ -0,0 +1,54 @@
+/*
+Copyright 2025 The Flux authors
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package controller
+
+import (
+	"sigs.k8s.io/controller-runtime/pkg/event"
+	"sigs.k8s.io/controller-runtime/pkg/predicate"
+
+	"github.com/fluxcd/pkg/runtime/conditions"
+
+	kustomizev1 "github.com/fluxcd/kustomize-controller/api/v1"
+)
+
+type KustomizationReadyChangePredicate struct {
+	predicate.Funcs
+}
+
+func (KustomizationReadyChangePredicate) Update(e event.UpdateEvent) bool {
+	if e.ObjectNew == nil || e.ObjectOld == nil {
+		return false
+	}
+
+	newKs, ok := e.ObjectNew.(*kustomizev1.Kustomization)
+	if !ok {
+		return false
+	}
+	oldKs, ok := e.ObjectOld.(*kustomizev1.Kustomization)
+	if !ok {
+		return false
+	}
+
+	if !conditions.IsReady(newKs) {
+		return false
+	}
+	if !conditions.IsReady(oldKs) {
+		return true
+	}
+
+	return oldKs.Status.LastAppliedRevision != newKs.Status.LastAppliedRevision
+}

internal/controller/kustomization_controller.go

@@ -138,6 +138,12 @@ func (r *KustomizationReconciler) SetupWithManager(ctx context.Context, mgr ctrl
 		return fmt.Errorf("failed setting index fields: %w", err)
 	}
 
+	// Index the Kustomizations by the dependsOn references they (may) point at.
+	if err := mgr.GetCache().IndexField(ctx, &kustomizev1.Kustomization{}, dependsOnIndexKey,
+		r.indexDependsOn); err != nil {
+		return fmt.Errorf("failed setting index fields: %w", err)
+	}
+
 	r.requeueDependency = opts.DependencyRequeueInterval
 	r.statusManager = fmt.Sprintf("gotk-%s", r.ControllerName)
 	r.artifactFetchRetries = opts.HTTPRetry
@@ -161,6 +167,11 @@ func (r *KustomizationReconciler) SetupWithManager(ctx context.Context, mgr ctrl
 			handler.EnqueueRequestsFromMapFunc(r.requestsForRevisionChangeOf(bucketIndexKey)),
 			builder.WithPredicates(SourceRevisionChangePredicate{}),
 		).
+		Watches(
+			&kustomizev1.Kustomization{},
+			handler.EnqueueRequestsFromMapFunc(r.requestsForDependents),
+			builder.WithPredicates(KustomizationReadyChangePredicate{}),
+		).
 		WithOptions(controller.Options{
 			RateLimiter: opts.RateLimiter,
 		}).
@@ -271,10 +282,10 @@ func (r *KustomizationReconciler) Reconcile(ctx context.Context, req ctrl.Reques
 	if len(obj.Spec.DependsOn) > 0 {
 		if err := r.checkDependencies(ctx, obj, artifactSource); err != nil {
 			conditions.MarkFalse(obj, meta.ReadyCondition, meta.DependencyNotReadyReason, "%s", err)
-			msg := fmt.Sprintf("Dependencies do not meet ready condition, retrying in %s", r.requeueDependency.String())
-			log.Info(msg)
+			msg := "Dependencies do not meet ready condition, waiting"
+			log.Info(msg, "err", err)
 			r.event(obj, revision, originRevision, eventv1.EventSeverityInfo, msg, nil)
-			return ctrl.Result{RequeueAfter: r.requeueDependency}, nil
+			return ctrl.Result{}, nil
 		}
 		log.Info("All dependencies are ready, proceeding with reconciliation")
 	}

internal/controller/kustomization_indexers.go

@@ -21,17 +21,24 @@ import (
 	"fmt"
 
 	"github.com/fluxcd/pkg/runtime/conditions"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/types"
 	ctrl "sigs.k8s.io/controller-runtime"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/handler"
 	"sigs.k8s.io/controller-runtime/pkg/reconcile"
 
+	"github.com/fluxcd/pkg/apis/meta"
 	"github.com/fluxcd/pkg/runtime/dependency"
 	sourcev1 "github.com/fluxcd/source-controller/api/v1"
 
 	kustomizev1 "github.com/fluxcd/kustomize-controller/api/v1"
 )
 
+const (
+	dependsOnIndexKey string = ".metadata.dependsOn"
+)
+
 func (r *KustomizationReconciler) requestsForRevisionChangeOf(indexKey string) handler.MapFunc {
 	return func(ctx context.Context, obj client.Object) []reconcile.Request {
 		log := ctrl.LoggerFrom(ctx)
@@ -78,6 +85,53 @@ func (r *KustomizationReconciler) requestsForRevisionChangeOf(indexKey string) h
 	}
 }
 
+func isNotReadyForDependency(k *kustomizev1.Kustomization) bool {
+	c := conditions.Get(k, meta.ReadyCondition)
+	if c == nil {
+		return false
+	}
+	return c.Status == metav1.ConditionFalse && c.Reason == meta.DependencyNotReadyReason
+}
+
+func (r *KustomizationReconciler) requestsForDependents(ctx context.Context, obj client.Object) []reconcile.Request {
+	log := ctrl.LoggerFrom(ctx)
+
+	var list kustomizev1.KustomizationList
+	if err := r.List(ctx, &list, client.MatchingFields{
+		dependsOnIndexKey: client.ObjectKeyFromObject(obj).String(),
+	}); err != nil {
+		log.Error(err, "failed to list objects for dependency change")
+		return nil
+	}
+	var dd []dependency.Dependent
+	for _, d := range list.Items {
+		if isNotReadyForDependency(&d) {
+			dd = append(dd, &d)
+		}
+	}
+	sorted, err := dependency.Sort(dd)
+	if err != nil {
+		log.Error(err, "failed to sort dependents for dependency change")
+		return nil
+	}
+	reqs := make([]reconcile.Request, 0, len(sorted))
+	debugLog := log.V(1).WithValues("dependency", map[string]string{
+		"name":      obj.GetName(),
+		"namespace": obj.GetNamespace(),
+	})
+	for _, d := range sorted {
+		debugLog.Info("requesting reconciliation of dependent", "dependent", map[string]string{
+			"name":      d.Name,
+			"namespace": d.Namespace,
+		})
+		reqs = append(reqs, reconcile.Request{NamespacedName: types.NamespacedName{
+			Name:      d.Name,
+			Namespace: d.Namespace,
+		}})
+	}
+	return reqs
+}
+
 func (r *KustomizationReconciler) indexBy(kind string) func(o client.Object) []string {
 	return func(o client.Object) []string {
 		k, ok := o.(*kustomizev1.Kustomization)
@@ -96,3 +150,21 @@ func (r *KustomizationReconciler) indexBy(kind string) func(o client.Object) []s
 		return nil
 	}
 }
+
+func (r *KustomizationReconciler) indexDependsOn(o client.Object) []string {
+	k, ok := o.(*kustomizev1.Kustomization)
+	if !ok {
+		panic(fmt.Sprintf("Expected a Kustomization, got %T", o))
+	}
+
+	deps := make([]string, len(k.Spec.DependsOn))
+	for i, dep := range k.Spec.DependsOn {
+		namespace := k.GetNamespace()
+		if dep.Namespace != "" {
+			namespace = dep.Namespace
+		}
+		deps[i] = fmt.Sprintf("%s/%s", namespace, dep.Name)
+	}
+
+	return deps
+}