-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(adiru+a32nx/fwc/fms): add irs alignment messages/faults, quick re-align, move gps primary #10169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Use the ARINC429 SSM definition for what is invalid.
CYLT, 82°31'1.8"N 062°17'4.3"W |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the Rust perspective looks good.
Co-authored-by: Pascal Störzbach <[email protected]>
This reverts commit 7d5a8e2.
Fix the ext clock to use the simvar that already exists, and make the bus topics safe.
I will do the A380X FWS amendments once this PR is merged |
Quality Assurance Tester Report Discord Username : jonny_23 Testing Process:
Testing Results: Negatives:
Conclusions: |
Possibly excess motion during alignment? It does have a filter, but large spikes would still trip it, resetting the alignment to the start and making it flash. If it proves to be a common issue I would build a better filter in the rust lib that can reject spikes. |
Yea ok, I haven't noticed it again so it may have been a one off occurrence. The aircraft wasn't moving at the time though? |
I found that when you start boarding during the alignement that that is noticed as an excessive movement. Align message starts flashing and begins at >7 min again. |
Are you using the Realistic or the Fast/Instant boarding setting? |
I'm using fast boarding. |
Fixes #291
Summary of Changes
The A380X FWC should really get some work around these areas, especially to remove the REMAINING_ALIGN_TIME Lvar, but I am not so familiar with either the structure of ours, or the logic of the real one.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
Set your IRS alignment time to realistic for all tests unless mentioned.
Spawn on the apron:
Align each IRS separately and individually and ensure the ECAM shows a reasonable alignment time (5 minutes at the equator, up to 10 minutes at 60° of latitude, then a step to 17 minutes above 73°).
With IRs fully aligned, switch IR1 off and immediately back on, it should go through a quick 3 minute re-alignment
Repeat alignment but start an engine and move the plane.. you should get an IRS NOT ALIGNED warning with EXCESS MOTION
If you can find an airport above 82° N or S you can try spawn there and align (CYLT). It should fail to align (flashing during align, then amber and finally ALIGN FAULT after starting both engines).
Spawn in the air and ensure the IRs are fully aligned and remain so.
Spawn on the runway and ensure the IRs are fully aligned and remain so.
Perform a full flight starting cold & dark, and ensure no IRS anomalies occur.
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.