Skip to content

Conversation

tracernz
Copy link
Member

@tracernz tracernz commented Jun 21, 2025

Fixes #291

Summary of Changes

  • Add excess motion, alignment fault due to high latitude (>|82°|) to the IRS
  • Add quick re-align to the IRS
  • Add realistic alignment times for the IRS (as low as 5 minutes at the equator, and up to 17 minutes at high latitudes)
  • Add IRS related status outputs to the DMC for the FWC to consume
  • Added IRS alignment faults to the FWC and fixed the logic for the time to align (can't remove the old var from the ADIRU yet as the A380X is still using it)
  • Add a DMC clock source synced across all the displays on a DMC using the monotonic clock from the sim
  • Add flashing text to the EWD, and fix typo with underline
  • Use the DMC clock source for the PFD and EWD flashing
  • Moved the GPS PRIMARY logic from the ADIRU to the FMS where it belongs

The A380X FWC should really get some work around these areas, especially to remove the REMAINING_ALIGN_TIME Lvar, but I am not so familiar with either the structure of ours, or the logic of the real one.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Set your IRS alignment time to realistic for all tests unless mentioned.

Spawn on the apron:

  • Align each IRS separately and individually and ensure the ECAM shows a reasonable alignment time (5 minutes at the equator, up to 10 minutes at 60° of latitude, then a step to 17 minutes above 73°).

  • With IRs fully aligned, switch IR1 off and immediately back on, it should go through a quick 3 minute re-alignment

  • Repeat alignment but start an engine and move the plane.. you should get an IRS NOT ALIGNED warning with EXCESS MOTION

  • If you can find an airport above 82° N or S you can try spawn there and align (CYLT). It should fail to align (flashing during align, then amber and finally ALIGN FAULT after starting both engines).

  • Spawn in the air and ensure the IRs are fully aligned and remain so.

  • Spawn on the runway and ensure the IRs are fully aligned and remain so.

  • Perform a full flight starting cold & dark, and ensure no IRS anomalies occur.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@tracernz tracernz added this to the v0.14.0 milestone Jun 21, 2025
@github-project-automation github-project-automation bot moved this to 🟡 Code Review: Ready for Review in Quality Assurance Jun 21, 2025
@tracernz tracernz changed the title feat(adiru+a32nx/fwc/fms): add irs alignment messages, excess motion and alignment fauts, move gps primary feat(adiru+a32nx/fwc/fms): add irs alignment messages/faults, quick re-align, move gps primary Jun 21, 2025
@pinatacolada
Copy link
Contributor

pinatacolada commented Jun 21, 2025

If you can find an airport above 82° N or S you can try spawn there and align, but I don't think any exist...

CYLT, 82°31'1.8"N 062°17'4.3"W

Copy link
Contributor

@Gurgel100 Gurgel100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the Rust perspective looks good.

Co-authored-by: Pascal Störzbach <[email protected]>
tracernz added 2 commits July 5, 2025 16:03
Fix the ext clock to use the simvar that already exists, and make the
bus topics safe.
@github-project-automation github-project-automation bot moved this from 🟡 Code Review: Ready for Review to 🔴 Code Review: In progress in Quality Assurance Jul 12, 2025
@flogross89
Copy link
Contributor

I will do the A380X FWS amendments once this PR is merged

@github-project-automation github-project-automation bot moved this from 🔴 Code Review: In progress to 🟣 QA Review: Ready to Test in Quality Assurance Jul 12, 2025
@tracernz tracernz moved this from 🟣 QA Review: Ready to Test to ⌛ Awaiting Actions in Quality Assurance Jul 31, 2025
@tracernz tracernz added the Not Ready For Testing Not ready for testing as still being discussed or developed. label Jul 31, 2025
@tracernz tracernz removed the Not Ready For Testing Not ready for testing as still being discussed or developed. label Aug 1, 2025
@tracernz tracernz moved this from ⌛ Awaiting Actions to 🟣 QA Review: Ready to Test in Quality Assurance Aug 1, 2025
@Jonny23787
Copy link
Contributor

Quality Assurance Tester Report

Discord Username : jonny_23
Object of testing : #10169
Aircraft : A32NX
Simulator : 2020
Tier of Testing : 2
Date : 03/08/2025

Testing Process:

  1. Aligned IRS separately, confirmed they showed a reasonable alignment time.
  2. Once aligned, quickly switched IR 1 off then on, confirmed it went through a quick 3 min alignment.
  3. Started realigning all IRS again, moved aircraft and started engines, confirmed faults appeared on EWD.
  4. Spawned at CYLT, attempted to align IRS, confirmed it failed to align and message flashed. Confirmed amber ALIGN FAULT appeared when both engines were started.
  5. Spawned aircraft in air, confirmed IRS were aligned properly and remained so.
  6. Spawned aircraft on runway, confirmed IRS were aligned properly and remained so.
  7. Completed a full flight from FACT to FALE. No IRS errors.

Testing Results:
Passed

Negatives:

  • I'm fairly sure the IRS align message was flashing when aligning at FACT for the full flight test. I have retested and attempted to replicate this however it didn't seem to occur again.

Conclusions:

Media:
Screenshot 2025-08-03 112124
Screenshot 2025-08-03 114122

@tracernz
Copy link
Member Author

tracernz commented Aug 5, 2025

I'm fairly sure the IRS align message was flashing when aligning at FACT for the full flight test. I have retested and attempted to replicate this however it didn't seem to occur again.

Possibly excess motion during alignment? It does have a filter, but large spikes would still trip it, resetting the alignment to the start and making it flash. If it proves to be a common issue I would build a better filter in the rust lib that can reject spikes.

@Jonny23787
Copy link
Contributor

Yea ok, I haven't noticed it again so it may have been a one off occurrence. The aircraft wasn't moving at the time though?

@tracernz tracernz enabled auto-merge (squash) August 5, 2025 10:30
@tracernz tracernz merged commit 6cf76fd into flybywiresim:master Aug 5, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from 🟣 QA Review: Ready to Test to ✔️ Done in Quality Assurance Aug 5, 2025
@MStallen
Copy link

MStallen commented Sep 5, 2025

I found that when you start boarding during the alignement that that is noticed as an excessive movement. Align message starts flashing and begins at >7 min again.
I don't think that's happening in real live.

@flogross89
Copy link
Contributor

I found that when you start boarding during the alignement that that is noticed as an excessive movement. Align message starts flashing and begins at >7 min again. I don't think that's happening in real live.

Are you using the Realistic or the Fast/Instant boarding setting?

@MStallen
Copy link

MStallen commented Sep 6, 2025

I'm using fast boarding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

IRS align should cancel if the plane is moved
8 participants