-
Notifications
You must be signed in to change notification settings - Fork 20
Add integration tests #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pingsutw
wants to merge
8
commits into
main
Choose a base branch
from
integration_tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
pingsutw
commented
Sep 5, 2025
Comment on lines
+7
to
+8
| pull_request: | ||
| types: [opened, synchronize, reopened, ready_for_review] |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert it before merging pr
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Member
Author
|
debugging, there is a module loading issue |
Signed-off-by: Kevin Su <[email protected]>
Member
Author
|
fixed it |
kumare3
reviewed
Sep 6, 2025
| r.wait() | ||
|
|
||
|
|
||
| if __name__ == "__main__": |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just use pytest integration test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces automated integration testing for the project by adding a GitHub Actions workflow and an example integration test script. The workflow ensures that integration tests are run on every push and pull request to the
mainbranch, and supports testing across multiple Python versions. The integration test script initializes the Flyte SDK and runs a sample workflow, verifying connectivity and basic execution.Continuous Integration Setup:
.github/workflows/integration_tests.ymlto define a GitHub Actions workflow that runs integration tests on pushes and pull requests to themainbranch, testing on Python 3.10 and 3.13.Integration Testing:
examples/integration_tests.pyto initialize the Flyte SDK and execute themainworkflow frombasics.hello, printing run URLs and waiting for completion.