Skip to content

Conversation

@pingsutw
Copy link
Member

@pingsutw pingsutw commented Sep 5, 2025

This pull request introduces automated integration testing for the project by adding a GitHub Actions workflow and an example integration test script. The workflow ensures that integration tests are run on every push and pull request to the main branch, and supports testing across multiple Python versions. The integration test script initializes the Flyte SDK and runs a sample workflow, verifying connectivity and basic execution.

Continuous Integration Setup:

  • Added .github/workflows/integration_tests.yml to define a GitHub Actions workflow that runs integration tests on pushes and pull requests to the main branch, testing on Python 3.10 and 3.13.

Integration Testing:

  • Created examples/integration_tests.py to initialize the Flyte SDK and execute the main workflow from basics.hello, printing run URLs and waiting for completion.

Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Comment on lines +7 to +8
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert it before merging pr

Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
@pingsutw
Copy link
Member Author

pingsutw commented Sep 5, 2025

debugging, there is a module loading issue

"/opt/venv/lib/python3.10/site-packages/flyte/_internal/resolvers/default.py", 
line 22, in load_task
    task_module = importlib.import_module(name=task_module)  # type: ignore
  File "/usr/local/lib/python3.10/importlib/__init__.py", line 126, in 
import_module
    return _bootstrap._gcd_import(name, package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/root/./examples/integration_tests.py", line 4, in <module>
    from basics.hello import main, env
ModuleNotFoundError: No module named 'basics'

Signed-off-by: Kevin Su <[email protected]>
@pingsutw
Copy link
Member Author

pingsutw commented Sep 5, 2025

fixed it

r.wait()


if __name__ == "__main__":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just use pytest integration test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants