improve coverage and fix bad var handling

Signed-off-by: ttitsworth-fsp <[email protected]>

Author: ttitsworth-lila

flyteadmin/pkg/manager/impl/execution_manager.go

@@ -2066,6 +2066,12 @@ func (m *ExecutionManager) addIdentityAnnotations(ctx context.Context, initialAn
 	// Get identity from authentication context
 	identityContext := auth.IdentityContextFromContext(ctx)
 
+	// Check if identity context is empty
+	if identityContext.IsEmpty() {
+		logger.Debugf(ctx, "No identity information found in context, skipping identity annotation injection")
+		return initialAnnotations
+	}
+
 	if initialAnnotations == nil {
 		initialAnnotations = make(map[string]string)
 	}
@@ -2075,12 +2081,7 @@ func (m *ExecutionManager) addIdentityAnnotations(ctx context.Context, initialAn
 
 	// Determine if this is an app or user identity
 	isAppIdentity := identityContext.AppID() != ""
-	isUserIdentity := identityContext.UserInfo() != nil
-
-	if !isAppIdentity && !isUserIdentity {
-		logger.Debugf(ctx, "No identity information found in context, skipping identity annotation injection")
-		return initialAnnotations
-	}
+	isUserIdentity := identityContext.UserInfo() != nil && !isAppIdentity
 
 	// Add annotations based on identity type
 	if isAppIdentity {

flyteadmin/pkg/manager/impl/execution_manager_test.go

@@ -6568,4 +6568,5 @@ func TestAddIdentityAnnotations(t *testing.T) {
 		assert.NotContains(t, result, "flyte.ai/user-unknown-key")
 		assert.Equal(t, "value", result["existing"])
 	})
+
 }