fix up no lint

Signed-off-by: Jason Parraga <[email protected]>

Author: Sovietaced

flyteadmin/pkg/errors/errors.go

@@ -215,5 +215,5 @@ func NewInactiveProjectError(ctx context.Context, id string) FlyteAdminError {
 }
 
 func NewInvalidLiteralTypeError(name string, err error) FlyteAdminError {
-	return NewFlyteAdminErrorf(codes.InvalidArgument, "Failed to validate literal type for [%s] with err: %s", name, err) //nolint
+	return NewFlyteAdminErrorf(codes.InvalidArgument, "Failed to validate literal type for [%s] with err: %s", name, err)
 }

flytectl/cmd/update/execution.go

@@ -37,13 +37,13 @@ func updateExecutionFunc(ctx context.Context, args []string, cmdCtx cmdCore.Comm
 	project := config.GetConfig().Project
 	domain := config.GetConfig().Domain
 	if len(args) != 1 {
-		return errors.New(clierrors.ErrExecutionNotPassed) //nolint
+		return errors.New(clierrors.ErrExecutionNotPassed)
 	}
 	executionName := args[0]
 	activate := execution.UConfig.Activate
 	archive := execution.UConfig.Archive
 	if activate && archive {
-		return errors.New(clierrors.ErrInvalidStateUpdate) //nolint
+		return errors.New(clierrors.ErrInvalidStateUpdate)
 	}
 
 	var newState admin.ExecutionState

flytectl/cmd/update/launch_plan.go

@@ -37,12 +37,12 @@ func updateLPFunc(ctx context.Context, args []string, cmdCtx cmdCore.CommandCont
 	project := config.GetConfig().Project
 	domain := config.GetConfig().Domain
 	if len(args) != 1 {
-		return errors.New(clierrors.ErrLPNotPassed) //nolint
+		return errors.New(clierrors.ErrLPNotPassed)
 	}
 	name := args[0]
 	version := launchplan.UConfig.Version
 	if len(version) == 0 {
-		return errors.New(clierrors.ErrLPVersionNotPassed) //nolint
+		return errors.New(clierrors.ErrLPVersionNotPassed)
 	}
 
 	activate := launchplan.UConfig.Activate
@@ -56,7 +56,7 @@ func updateLPFunc(ctx context.Context, args []string, cmdCtx cmdCore.CommandCont
 		deactivate = launchplan.UConfig.Deactivate
 	}
 	if activate == deactivate && deactivate {
-		return errors.New(clierrors.ErrInvalidBothStateUpdate) //nolint
+		return errors.New(clierrors.ErrInvalidBothStateUpdate)
 	}
 
 	var newState admin.LaunchPlanState

flytectl/cmd/update/launch_plan_meta.go

@@ -38,7 +38,7 @@ func getUpdateLPMetaFunc(namedEntityConfig *NamedEntityConfig) func(ctx context.
 		project := config.GetConfig().Project
 		domain := config.GetConfig().Domain
 		if len(args) != 1 {
-			return errors.New(clierrors.ErrLPNotPassed) //nolint
+			return errors.New(clierrors.ErrLPNotPassed)
 		}
 		name := args[0]
 		err := namedEntityConfig.UpdateNamedEntity(ctx, name, project, domain, core.ResourceType_LAUNCH_PLAN, cmdCtx)

flytectl/cmd/update/named_entity.go

@@ -29,7 +29,7 @@ type NamedEntityConfig struct {
 
 func (cfg NamedEntityConfig) UpdateNamedEntity(ctx context.Context, name string, project string, domain string, rsType core.ResourceType, cmdCtx cmdCore.CommandContext) error {
 	if cfg.Activate && cfg.Archive {
-		return errors.New(clierrors.ErrInvalidStateUpdate) //nolint
+		return errors.New(clierrors.ErrInvalidStateUpdate)
 	}
 
 	id := &admin.NamedEntityIdentifier{

flytectl/cmd/update/project.go

@@ -105,7 +105,7 @@ func updateProjectsFunc(ctx context.Context, args []string, cmdCtx cmdCore.Comma
 	}
 
 	if edits.GetId() == "" {
-		return errors.New(clierrors.ErrProjectNotPassed) //nolint
+		return errors.New(clierrors.ErrProjectNotPassed)
 	}
 
 	currentProject, err := cmdCtx.AdminFetcherExt().GetProjectByID(ctx, edits.GetId())

flytectl/cmd/update/workflow_meta.go

@@ -38,7 +38,7 @@ func getUpdateWorkflowFunc(namedEntityConfig *NamedEntityConfig) func(ctx contex
 		project := config.GetConfig().Project
 		domain := config.GetConfig().Domain
 		if len(args) != 1 {
-			return errors.New(clierrors.ErrWorkflowNotPassed) //nolint
+			return errors.New(clierrors.ErrWorkflowNotPassed)
 		}
 		name := args[0]
 		err := namedEntityConfig.UpdateNamedEntity(ctx, name, project, domain, core.ResourceType_WORKFLOW, cmdCtx)

flyteidl/clients/go/admin/auth_interceptor.go

@@ -236,7 +236,7 @@ func NewAuthInterceptor(cfg *Config, tokenCache cache.TokenCache, credentialsFut
 						logger.Debugf(ctx, "Request failed due to [%v]. Attempting to establish an authenticated connection and trying again.", st.Code())
 						newErr := MaterializeCredentials(tokenSource, cfg, authorizationMetadataKey, credentialsFuture)
 						if newErr != nil {
-							return errors.New(fmt.Sprintf("authentication error! Original Error: %v, Auth Error: %v", err, newErr)) //nolint
+							return errors.New(fmt.Sprintf("authentication error! Original Error: %v, Auth Error: %v", err, newErr))
 						}
 
 						tokenCache.CondBroadcast()

flyteplugins/go/tasks/plugins/array/k8s/management.go

@@ -390,7 +390,7 @@ func TerminateSubTasks(ctx context.Context, tCtx core.TaskExecutionContext, kube
 	}
 
 	if messageCollector.Length() > 0 {
-		return currentState, externalResources, errors.New(messageCollector.Summary(config.MaxErrorStringLength)) //nolint
+		return currentState, externalResources, errors.New(messageCollector.Summary(config.MaxErrorStringLength))
 	}
 
 	return currentState.SetPhase(arrayCore.PhaseWriteToDiscoveryThenFail, currentState.PhaseVersion+1), externalResources, nil

flytestdlib/storage/copy_impl_test.go

@@ -97,12 +97,11 @@ func TestCopyRaw_CachingErrorHandling(t *testing.T) {
 		store := dummyStore{
 			ReadRawCb: func(ctx context.Context, reference DataReference) (closer io.ReadCloser, e error) {
 				readerCalled = true
-				//nolint:govet,staticcheck
 				return ioutils.NewBytesReadCloser(bigD), flyteErr.Wrapf(ErrFailedToWriteCache, errors.New(dummyErrorMsg), "Failed to Cache the metadata")
 			},
 			WriteRawCb: func(ctx context.Context, reference DataReference, size int64, opts Options, raw io.Reader) error {
 				writerCalled = true
-				return flyteErr.Wrapf(ErrFailedToWriteCache, errors.New(dummyErrorMsg), "Failed to Cache the metadata") //nolint:govet,staticcheck
+				return flyteErr.Wrapf(ErrFailedToWriteCache, errors.New(dummyErrorMsg), "Failed to Cache the metadata")
 			},
 		}
 
@@ -124,11 +123,11 @@ func TestCopyRaw_CachingErrorHandling(t *testing.T) {
 		store := dummyStore{
 			ReadRawCb: func(ctx context.Context, reference DataReference) (closer io.ReadCloser, e error) {
 				readerCalled = true
-				return ioutils.NewBytesReadCloser(bigD), errors.New(dummyErrorMsg) //nolint:govet,staticcheck
+				return ioutils.NewBytesReadCloser(bigD), errors.New(dummyErrorMsg)
 			},
 			WriteRawCb: func(ctx context.Context, reference DataReference, size int64, opts Options, raw io.Reader) error {
 				writerCalled = true
-				return errors.New(dummyErrorMsg) //nolint:govet,staticcheck
+				return errors.New(dummyErrorMsg)
 			},
 		}