using negative interruptibleFailureThreshold as complementary (#403)

hamersaw · web-flow · commit 445fc589ac85 · 2023-09-29T09:38:42.000-05:00
Signed-off-by: Daniel Rammer &lt;daniel@union.ai&gt;
diff --git a/go/tasks/pluginmachinery/core/exec_metadata.go b/go/tasks/pluginmachinery/core/exec_metadata.go
@@ -44,6 +44,6 @@ type TaskExecutionMetadata interface {
 	GetSecurityContext() core.SecurityContext
 	IsInterruptible() bool
 	GetPlatformResources() *v1.ResourceRequirements
-	GetInterruptibleFailureThreshold() uint32
+	GetInterruptibleFailureThreshold() int32
 	GetEnvironmentVariables() map[string]string
 }
diff --git a/go/tasks/pluginmachinery/core/mocks/task_execution_metadata.go b/go/tasks/pluginmachinery/core/mocks/task_execution_metadata.go
diff --git a/go/tasks/plugins/array/k8s/subtask_exec_context.go b/go/tasks/plugins/array/k8s/subtask_exec_context.go
@@ -268,7 +268,7 @@ func NewSubTaskExecutionMetadata(taskExecutionMetadata pluginsCore.TaskExecution
 	}
 
 	subTaskExecutionID := NewSubTaskExecutionID(taskExecutionMetadata.GetTaskExecutionID(), executionIndex, retryAttempt)
-	interruptible := taskExecutionMetadata.IsInterruptible() && uint32(systemFailures) < taskExecutionMetadata.GetInterruptibleFailureThreshold()
+	interruptible := taskExecutionMetadata.IsInterruptible() && int32(systemFailures) < taskExecutionMetadata.GetInterruptibleFailureThreshold()
 	return SubTaskExecutionMetadata{
 		taskExecutionMetadata,
 		utils.UnionMaps(taskExecutionMetadata.GetAnnotations(), secretsMap),

Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,6 @@ type TaskExecutionMetadata interface {`
`44`	`44`	`GetSecurityContext() core.SecurityContext`
`45`	`45`	`IsInterruptible() bool`
`46`	`46`	`GetPlatformResources() *v1.ResourceRequirements`
`47`		`- GetInterruptibleFailureThreshold() uint32`
	`47`	`+ GetInterruptibleFailureThreshold() int32`
`48`	`48`	`GetEnvironmentVariables() map[string]string`
`49`	`49`	`}`
Original file line number	Diff line number	Diff line change
`@@ -268,7 +268,7 @@ func NewSubTaskExecutionMetadata(taskExecutionMetadata pluginsCore.TaskExecution`
`268`	`268`	`}`
`269`	`269`
`270`	`270`	`subTaskExecutionID := NewSubTaskExecutionID(taskExecutionMetadata.GetTaskExecutionID(), executionIndex, retryAttempt)`
`271`		`- interruptible := taskExecutionMetadata.IsInterruptible() && uint32(systemFailures) < taskExecutionMetadata.GetInterruptibleFailureThreshold()`
	`271`	`+ interruptible := taskExecutionMetadata.IsInterruptible() && int32(systemFailures) < taskExecutionMetadata.GetInterruptibleFailureThreshold()`
`272`	`272`	`return SubTaskExecutionMetadata{`
`273`	`273`	`taskExecutionMetadata,`
`274`	`274`	`utils.UnionMaps(taskExecutionMetadata.GetAnnotations(), secretsMap),`