Bugfix/1168 #1169
Merged
Bugfix/1168 #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueqbit
approved these changes
Mar 26, 2023
There was a problem hiding this comment.
Argh, stupid mistake!
I suggest we use the same C string literal "SELECT name FROM sqlite_master WHERE type='table'" as in storage_base::table_names() below in order to benefit from string pooling.
|
@trueqbit well it is not yours it is mine cause all you did is refactored existing quotes |
I have to disappoint you - it was my mistake 🤣, see #d470ca12b062 |
it shows me 404. Even if it is made by you - no problem. |
tserong
added a commit
to tserong/ceph
that referenced
this pull request
Sep 19, 2023
sqlite_orm v1.8.2 has fnc12/sqlite_orm#1054, which I need for thread safety. Unfortunately it's missing fnc12/sqlite_orm#1169, without which storage.sync_schema() breaks (or at least gives us nasty errors) due to incorrect quotes. In order to pick up the latter, I've forked sqlite_orm into the aquarist-labs org, and made a branch "v1.8.2-s3gw", which is upstream v1.8.2 plus a cherry pick of that additional fix. Signed-off-by: Tim Serong <[email protected]>
tserong
added a commit
to tserong/ceph
that referenced
this pull request
Sep 19, 2023
sqlite_orm v1.8.2 has fnc12/sqlite_orm#1054, which I need for thread safety. Unfortunately it's missing fnc12/sqlite_orm#1169, without which storage.sync_schema() breaks (or at least gives us nasty errors) due to incorrect quotes. In order to pick up the latter, I've forked sqlite_orm into the aquarist-labs org, and made a branch "v1.8.2-s3gw", which is upstream v1.8.2 plus a cherry pick of that additional fix. Signed-off-by: Tim Serong <[email protected]>
tserong
added a commit
to tserong/ceph
that referenced
this pull request
Sep 20, 2023
sqlite_orm v1.8.2 has fnc12/sqlite_orm#1054, which I need for thread safety. Unfortunately it's missing fnc12/sqlite_orm#1169, without which storage.sync_schema() breaks (or at least gives us nasty errors) due to incorrect quotes. In order to pick up the latter, I've forked sqlite_orm into the aquarist-labs org, and made a branch "v1.8.2-s3gw", which is upstream v1.8.2 plus a cherry pick of that additional fix. Signed-off-by: Tim Serong <[email protected]>
tserong
added a commit
to tserong/ceph
that referenced
this pull request
Sep 20, 2023
sqlite_orm v1.8.2 has fnc12/sqlite_orm#1054, which I need for thread safety. Unfortunately it's missing fnc12/sqlite_orm#1169, without which storage.sync_schema() breaks (or at least gives us nasty errors) due to incorrect quotes. In order to pick up the latter, I've forked sqlite_orm into the aquarist-labs org, and made a branch "v1.8.2-s3gw", which is upstream v1.8.2 plus a cherry pick of that additional fix. Signed-off-by: Tim Serong <[email protected]>
tserong
added a commit
to tserong/ceph
that referenced
this pull request
Sep 25, 2023
sqlite_orm v1.8.2 has fnc12/sqlite_orm#1054, which I need for thread safety. Unfortunately it's missing fnc12/sqlite_orm#1169, without which storage.sync_schema() breaks (or at least gives us nasty errors) due to incorrect quotes. In order to pick up the latter, I've forked sqlite_orm into the aquarist-labs org, and made a branch "v1.8.2-s3gw", which is upstream v1.8.2 plus a cherry pick of that additional fix. Signed-off-by: Tim Serong <[email protected]>
tserong
added a commit
to tserong/ceph
that referenced
this pull request
Oct 14, 2023
sqlite_orm v1.8.2 has fnc12/sqlite_orm#1054, which I need for thread safety. Unfortunately it's missing fnc12/sqlite_orm#1169, without which storage.sync_schema() breaks (or at least gives us nasty errors) due to incorrect quotes. In order to pick up the latter, I've forked sqlite_orm into the aquarist-labs org, and made a branch "v1.8.2-s3gw", which is upstream v1.8.2 plus a cherry pick of that additional fix. Signed-off-by: Tim Serong <[email protected]>
tserong
added a commit
to tserong/ceph
that referenced
this pull request
Oct 17, 2023
sqlite_orm v1.8.2 has fnc12/sqlite_orm#1054, which I need for thread safety. Unfortunately it's missing fnc12/sqlite_orm#1169, without which storage.sync_schema() breaks (or at least gives us nasty errors) due to incorrect quotes. In order to pick up the latter, I've forked sqlite_orm into the aquarist-labs org, and made a branch "v1.8.2-s3gw", which is upstream v1.8.2 plus a cherry pick of that additional fix. Signed-off-by: Tim Serong <[email protected]>
tserong
added a commit
to tserong/ceph
that referenced
this pull request
Oct 17, 2023
sqlite_orm v1.8.2 has fnc12/sqlite_orm#1054, which we want to ensure thread safety. Unfortunately it's missing fnc12/sqlite_orm#1169, without which `storage.sync_schema()` breaks (or at least gives us nasty errors) due to incorrect quotes. In order to pick up the latter, I've forked sqlite_orm into the aquarist-labs org, and made a branch "v1.8.2-s3gw", which is upstream v1.8.2 plus a cherry pick of that additional fix. Signed-off-by: Tim Serong <[email protected]>
tserong
added a commit
to tserong/ceph
that referenced
this pull request
Oct 18, 2023
sqlite_orm v1.8.2 has fnc12/sqlite_orm#1054, which we want to ensure thread safety. Unfortunately it's missing fnc12/sqlite_orm#1169, without which `storage.sync_schema()` breaks (or at least gives us nasty errors) due to incorrect quotes. In order to pick up the latter, I've forked sqlite_orm into the aquarist-labs org, and made a branch "v1.8.2-s3gw", which is upstream v1.8.2 plus a cherry pick of that additional fix. Signed-off-by: Tim Serong <[email protected]>
tserong
added a commit
to tserong/ceph
that referenced
this pull request
Oct 19, 2023
sqlite_orm v1.8.2 has fnc12/sqlite_orm#1054, which we want to ensure thread safety. Unfortunately it's missing fnc12/sqlite_orm#1169, without which `storage.sync_schema()` breaks (or at least gives us nasty errors) due to incorrect quotes. In order to pick up the latter, I've forked sqlite_orm into the aquarist-labs org, and made a branch "v1.8.2-s3gw", which is upstream v1.8.2 plus a cherry pick of that additional fix. Signed-off-by: Tim Serong <[email protected]>
tserong
added a commit
to tserong/ceph
that referenced
this pull request
Oct 19, 2023
sqlite_orm v1.8.2 has fnc12/sqlite_orm#1054, which we want to ensure thread safety. Unfortunately it's missing fnc12/sqlite_orm#1169, without which `storage.sync_schema()` breaks (or at least gives us nasty errors) due to incorrect quotes. In order to pick up the latter, I've forked sqlite_orm into the aquarist-labs org, and made a branch "v1.8.2-s3gw", which is upstream v1.8.2 plus a cherry pick of that additional fix. Signed-off-by: Tim Serong <[email protected]>
tserong
added a commit
to tserong/ceph
that referenced
this pull request
Oct 25, 2023
sqlite_orm v1.8.2 has fnc12/sqlite_orm#1054, which we want to ensure thread safety. Unfortunately it's missing fnc12/sqlite_orm#1169, without which `storage.sync_schema()` breaks (or at least gives us nasty errors) due to incorrect quotes. In order to pick up the latter, I've forked sqlite_orm into the aquarist-labs org, and made a branch "v1.8.2-s3gw", which is upstream v1.8.2 plus a cherry pick of that additional fix. Signed-off-by: Tim Serong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #1168