Skip to content

Commit b691cbb

Browse files
committed
InsertBuilder should set string defaut for sqlx Select() (#78)
1 parent 6bb2ea5 commit b691cbb

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

builder_insert.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,6 @@ func (b *InsertBuilder) Set(k string, v interface{}) *InsertBuilder {
4949

5050
switch v.(type) {
5151
case string:
52-
if v.(string) == "" {
53-
return b
54-
}
5552
case uint64, uint, int64, int, int32, int16, int8, bool, byte, float64, float32:
5653
if v == 0 {
5754
return b

builder_x.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ package sqlxb
1818

1919
import "fmt"
2020

21-
// To build sql, like: SELECT DISTINCT f.id FROM foo f INNER_JOIN JOIN (SELECT foo_id FROM bar) b ON b.foo_id = f.id
21+
// ToId build sql, like: SELECT DISTINCT f.id FROM foo f INNER_JOIN JOIN (SELECT foo_id FROM bar) b ON b.foo_id = f.id
2222
// Sql for MySQL, Clickhouse....
2323
//
2424
// @author Sim

to_sql.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ func (built *Built) countBuilder() *strings.Builder {
266266

267267
func (built *Built) SqlOfPage() (string, string, []interface{}, map[string]string) {
268268
vs := []interface{}{}
269-
km := make(map[string]string) //nil for sub From builder,
269+
km := make(map[string]string) //nil for sub FromId builder,
270270
dataSql, kmp := built.sqlData(&vs, km)
271271
countSql := built.sqlCount()
272272

@@ -275,7 +275,7 @@ func (built *Built) SqlOfPage() (string, string, []interface{}, map[string]strin
275275

276276
func (built *Built) SqlOfSelect() (string, []interface{}, map[string]string) {
277277
vs := []interface{}{}
278-
km := make(map[string]string) //nil for sub From builder,
278+
km := make(map[string]string) //nil for sub FromId builder,
279279
dataSql, kmp := built.sqlData(&vs, km)
280280
return dataSql, vs, kmp
281281
}

0 commit comments

Comments
 (0)