-
Notifications
You must be signed in to change notification settings - Fork 28
Open
Description
Description
Hello, I love adding emojis to my commits and recently I found this repository to be a good tool to automate this process to me and also other devs of projects I work on. The thing is, I like TypeScript and have a tendency of not allowing any .js files in projects I work with. The fact this project only supported configuration file in .js format kind of bothered me a little, so I decided to add typescript support for the configuration file devmoji.config.ts.
The PR is here: #220
Type of change
- New feature (non-breaking change which adds functionality)
How Has This Been Tested?
I ran all the test suits with both yarn test and yarn test:cov and provided a new test to the new typescript configuration file.
- load typescript from config file
(Also tried to improve coverage a bit by adding a test for a uncovered scenario config file does not exist).
Checklist:
- My code follows the style guidelines of this project
- I have performed a self-review of my code
- I have commented my code, particularly in hard-to-understand areas
- I have made corresponding changes to the documentation
- My changes generate no new warnings
- I have added tests that prove my fix is effective or that my feature works
- New and existing unit tests pass locally with my changes
- Any dependent changes have been merged and published in downstream modules
Metadata
Metadata
Assignees
Labels
No labels
