Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review map layout #73

Open
pmackay opened this issue Jan 31, 2017 · 1 comment
Open

Review map layout #73

pmackay opened this issue Jan 31, 2017 · 1 comment

Comments

@pmackay
Copy link
Member

pmackay commented Jan 31, 2017

We attempted on VAC to make it static and fullwidth, but getting full height has not been achieved. Is fullwidth a problem on mobile if the map has filters?

@pmackay pmackay added this to the v0.2 Backlog milestone Jan 31, 2017
@djwesto
Copy link

djwesto commented Feb 2, 2017

I'm not confident I understand this very well. Looking at the Maps page using FF's responsive simulator shows some bad quality styling on that page with the filters looking messy and overlapping the header:

image

To answer what I think you mean:

We attempted on VAC to make it static and fullwidth, but getting full height has not been achieved
Yes, I see. It's not good – would be nice to get it to stretch to full height but not a deal breaker for this stage if it's too difficult. Would Flexbox help here?

Is fullwidth a problem on mobile if the map has filters?
I assume you're trying to suggest we stop it being full width and that this might somehow make the filters better? If we can improve the filters by stopping the map running full width that's probably worth the sacrifice but I honestly can't see how that might happen – surely, we need to improve the formatting of the filter controls?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants