Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single_line_tuples: space after comma? #36

Open
justvanrossum opened this issue Jan 22, 2025 · 2 comments
Open

single_line_tuples: space after comma? #36

justvanrossum opened this issue Jan 22, 2025 · 2 comments

Comments

@justvanrossum
Copy link

When using single_line_tuples, tuples are formatted like (123, 456). GlyphsApp, however, doesn't output the space after the comma and formats as (123,456).

if self.single_line_tuples:
dest.push_back(c' ')
count += 1

Do we want to (optionally) format like GlyphsApp? I'll gladly PR this.

Do we want to:

  1. Not bother, the openstep_plist package's goal does not include formatting like GlyphsApp
  2. Never output the space
  3. Optionally don't output the space

My preference would the the second option.

@justvanrossum
Copy link
Author

There are some additional GlyphsApp deviations that I'd like to address:

  • empty objects being spread over two lines instead of the single-line () and {}
  • binary data formatting

@justvanrossum
Copy link
Author

FWIW, I have fixes for all of these in this branch (which includes #35):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant