NEW (SFGE) @W-17915999@ Added SFGE telemetry support #269
Conversation
| @@ -188,7 +201,8 @@ function handleRunStdOut(stdOutMsg: string, emitLog: (logLevel: LogLevel, msg: s | |||
| for (const sfgeMessage of sfgeMessages) { | |||
| if (isSfgeLogMessage(sfgeMessage)) { | |||
| if (sfgeMessage.messageSeverity === 'TELEMETRY') { | |||
| // TODO: TELEMETRY | |||
| const telemetryData: TelemetryData = JSON.parse(sfgeMessage.args[0]) as TelemetryData; | |||
| emitTelemetry(telemetryData.eventName as string, telemetryData); | |||
There was a problem hiding this comment.
Technically, this means that the Telemetry Data will have its own redundant eventName parameter, but I don't believe that's worth getting into a tizzy over.
There was a problem hiding this comment.
Whenever possible, we should put JSON.parse in a try/catch in case we don't get the text in full or whatever. Probably could just log with trace level logging if it does fail and just continue as usual. But if you don't like the redundant stuff, then just recreate the data structure over here with what you want. Up to you.
| const engine: SfgeEngine = new SfgeEngine(configWithLowTimeout, fixedClock); | ||
| const workspace: Workspace = new Workspace('id', [path.join(TEST_DATA_FOLDER, 'sampleRelevantWorkspace')]); | ||
| const engine: SfgeEngine = new SfgeEngine(DEFAULT_SFGE_ENGINE_CONFIG, fixedClock); | ||
| const workspace: Workspace = new Workspace('id', [path.join(TEST_DATA_FOLDER, 'sampleUnhandledWorkspace')]); |
There was a problem hiding this comment.
Switched this test to work by scanning code that SFGE can't currently handle, instead of setting an absurdly low timeout. For whatever reason, the timeout failure wasn't reliably producing telemetry from within SFGE. That's something we may want to look into, but it's not within the scope of this story.
| @@ -0,0 +1,13 @@ | |||
| global virtual class MyStringHelper { | |||
There was a problem hiding this comment.
This code was pulled from Scanner issue #1177.
jfeingold35
force-pushed
the
d/W-17915999-3
branch
from
43eb178 to
7c84e87
Compare
jfeingold35
force-pushed
the
d/W-17915999-3
branch
from
7c84e87 to
0483d6a
Compare
This PR allows the SFGE engine to transmit telemetry events from the underlying Java module back up through the Typescript layer up to Core.