Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace var with let/const (#181) error #184

Open
kevinetore opened this issue Jan 9, 2020 · 3 comments
Open

Replace var with let/const (#181) error #184

kevinetore opened this issue Jan 9, 2020 · 3 comments

Comments

@kevinetore
Copy link

PR #181 seems to give the following error:

/usr/lib/node_modules/forever/node_modules/forever-monitor/lib/forever-monitor/monitor.js:38
let execPath = process.execPath;
^^^^^^^^
SyntaxError: Unexpected identifier
at Module._compile (module.js:439:25)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Module.require (module.js:364:17)
at require (module.js:380:17)
at Object.<anonymous> (/usr/lib/node_modules/forever/node_modules/forever-monitor/lib/index.js:14:19)
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32).
@kibertoad
Copy link
Contributor

What Node version are you using, and how can I reproduce?

@kevinetore
Copy link
Author

kevinetore commented Jan 9, 2020

@kibertoad Our app servers are using an older version of Node v6.17.1, which could be the reason why the newer syntax is failing on our machine. For now, I've downgraded the forever version to 1.0.0. Again, I assume that our Node version is the reason behind all this, so this issue can be marked as closed.

-- Update
I checked with this source which states that the let, const syntax should work with Node v6.17.1.

@kibertoad
Copy link
Contributor

@kevinetore We are actually running CI on 6.17.1 and it seems to be working just fine. Can you double-check that this is the version that is actually used? What do you get when running node --version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants