feat: add tests

Author: gfyrag

docs/api/README.md

@@ -117,18 +117,26 @@ Authorization ( Scopes: ledger:read )
 ```http
 GET http://localhost:8080/v2 HTTP/1.1
 Host: localhost:8080
+Content-Type: application/json
 Accept: application/json
 
 ```
 
 `GET /v2`
 
+> Body parameter
+
+```json
+{}
+```
+
 <h3 id="list-ledgers-parameters">Parameters</h3>
 
 |Name|In|Type|Required|Description|
 |---|---|---|---|---|
 |pageSize|query|integer(int64)|false|The maximum number of results to return per page.|
 |cursor|query|string|false|Parameter used in pagination requests. Maximum page size is set to 15.|
+|body|body|object|true|none|
 
 #### Detailed descriptions
 

go.mod

@@ -14,7 +14,7 @@ require (
 	github.com/antlr/antlr4/runtime/Go/antlr v1.4.10
 	github.com/bluele/gcache v0.0.2
 	github.com/dop251/goja v0.0.0-20241009100908-5f46f2705ca3
-	github.com/formancehq/go-libs/v2 v2.2.3-0.20250324165303-4a3b874e1f09
+	github.com/formancehq/go-libs/v2 v2.2.3-0.20250328155139-11198164d016
 	github.com/formancehq/ledger/pkg/client v0.0.0-00010101000000-000000000000
 	github.com/go-chi/chi/v5 v5.2.1
 	github.com/go-chi/cors v1.2.1

go.sum

@@ -104,8 +104,8 @@ github.com/fatih/color v1.18.0 h1:S8gINlzdQ840/4pfAwic/ZE0djQEH3wM94VfqLTZcOM=
 github.com/fatih/color v1.18.0/go.mod h1:4FelSpRwEGDpQ12mAdzqdOukCy4u8WUtOY6lkT/6HfU=
 github.com/felixge/httpsnoop v1.0.4 h1:NFTV2Zj1bL4mc9sqWACXbQFVBBg2W3GPvqp8/ESS2Wg=
 github.com/felixge/httpsnoop v1.0.4/go.mod h1:m8KPJKqk1gH5J9DgRY2ASl2lWCfGKXixSwevea8zH2U=
-github.com/formancehq/go-libs/v2 v2.2.3-0.20250324165303-4a3b874e1f09 h1:7AaCfyrCEXc7qjaIX24YAJzWI/FC+QmMA51nKXKOhN4=
-github.com/formancehq/go-libs/v2 v2.2.3-0.20250324165303-4a3b874e1f09/go.mod h1:/hrQ/BksJ/Usw8ONbtJeYU7jZ1pnWoM/4UsBQ0lSBbQ=
+github.com/formancehq/go-libs/v2 v2.2.3-0.20250328155139-11198164d016 h1:t2REX3SXrD4asj979f8pgRw/SfUPhYGxYZ7hkkP586w=
+github.com/formancehq/go-libs/v2 v2.2.3-0.20250328155139-11198164d016/go.mod h1:JvBjEDWNf7izCy2dq/eI3aMc9d28gChBe1rjw5yYlAs=
 github.com/formancehq/numscript v0.0.11 h1:vZDfRfrhOkuInv5fLIXvWZU3ylK+fVgmR4la01dO5to=
 github.com/formancehq/numscript v0.0.11/go.mod h1:btuSv05cYwi9BvLRxVs5zrunU+O1vTgigG1T6UsawcY=
 github.com/fortytw2/leaktest v1.3.0 h1:u8491cBMTQ8ft8aeV+adlcytMZylmA5nnwwkRZjI8vw=

internal/api/bulking/mocks_ledger_controller_test.go

@@ -2,7 +2,7 @@ package v1
 
 import (
 	"fmt"
-	"github.com/formancehq/ledger/internal/storage/resources"
+	storagecommon "github.com/formancehq/ledger/internal/storage/common"
 	"net/http"
 
 	"errors"
@@ -29,7 +29,7 @@ func countAccounts(w http.ResponseWriter, r *http.Request) {
 	count, err := l.CountAccounts(r.Context(), *rq)
 	if err != nil {
 		switch {
-		case errors.Is(err, resources.ErrInvalidQuery{}) || errors.Is(err, ledgercontroller.ErrMissingFeature{}):
+		case errors.Is(err, storagecommon.ErrInvalidQuery{}) || errors.Is(err, ledgercontroller.ErrMissingFeature{}):
 			api.BadRequest(w, common.ErrValidation, err)
 		default:
 			common.HandleCommonErrors(w, r, err)

internal/api/common/mocks_ledger_controller_test.go

@@ -2,7 +2,7 @@ package v1
 
 import (
 	"github.com/formancehq/ledger/internal/api/common"
-	"github.com/formancehq/ledger/internal/storage/resources"
+	storagecommon "github.com/formancehq/ledger/internal/storage/common"
 	"net/http"
 	"net/http/httptest"
 	"net/url"
@@ -25,7 +25,7 @@ func TestAccountsCount(t *testing.T) {
 	type testCase struct {
 		name              string
 		queryParams       url.Values
-		expectQuery       resources.ResourceQuery[any]
+		expectQuery       storagecommon.ResourceQuery[any]
 		expectStatusCode  int
 		expectedErrorCode string
 		returnErr         error
@@ -36,7 +36,7 @@ func TestAccountsCount(t *testing.T) {
 	testCases := []testCase{
 		{
 			name:              "nominal",
-			expectQuery:       resources.ResourceQuery[any]{},
+			expectQuery:       storagecommon.ResourceQuery[any]{},
 			expectBackendCall: true,
 		},
 		{
@@ -45,15 +45,15 @@ func TestAccountsCount(t *testing.T) {
 				"metadata[roles]": []string{"admin"},
 			},
 			expectBackendCall: true,
-			expectQuery: resources.ResourceQuery[any]{
+			expectQuery: storagecommon.ResourceQuery[any]{
 				Builder: query.Match("metadata[roles]", "admin"),
 			},
 		},
 		{
 			name:              "using address",
 			queryParams:       url.Values{"address": []string{"foo"}},
 			expectBackendCall: true,
-			expectQuery: resources.ResourceQuery[any]{
+			expectQuery: storagecommon.ResourceQuery[any]{
 				Builder: query.Match("address", "foo"),
 			},
 		},
@@ -63,7 +63,7 @@ func TestAccountsCount(t *testing.T) {
 			queryParams: url.Values{
 				"pageSize": []string{"1000000"},
 			},
-			expectQuery: resources.ResourceQuery[any]{},
+			expectQuery: storagecommon.ResourceQuery[any]{},
 		},
 		{
 			name: "using balance filter",
@@ -72,7 +72,7 @@ func TestAccountsCount(t *testing.T) {
 				"balance":         []string{"100"},
 			},
 			expectBackendCall: true,
-			expectQuery: resources.ResourceQuery[any]{
+			expectQuery: storagecommon.ResourceQuery[any]{
 				Builder: query.Lt("balance", int64(100)),
 			},
 		},
@@ -81,24 +81,24 @@ func TestAccountsCount(t *testing.T) {
 			expectStatusCode:  http.StatusBadRequest,
 			expectedErrorCode: common.ErrValidation,
 			expectBackendCall: true,
-			returnErr:         resources.ErrInvalidQuery{},
-			expectQuery:       resources.ResourceQuery[any]{},
+			returnErr:         storagecommon.ErrInvalidQuery{},
+			expectQuery:       storagecommon.ResourceQuery[any]{},
 		},
 		{
 			name:              "with missing feature",
 			expectStatusCode:  http.StatusBadRequest,
 			expectedErrorCode: common.ErrValidation,
 			expectBackendCall: true,
 			returnErr:         ledgercontroller.ErrMissingFeature{},
-			expectQuery:       resources.ResourceQuery[any]{},
+			expectQuery:       storagecommon.ResourceQuery[any]{},
 		},
 		{
 			name:              "with unexpected error",
 			expectStatusCode:  http.StatusInternalServerError,
 			expectedErrorCode: api.ErrorInternal,
 			expectBackendCall: true,
 			returnErr:         errors.New("undefined error"),
-			expectQuery:       resources.ResourceQuery[any]{},
+			expectQuery:       storagecommon.ResourceQuery[any]{},
 		},
 	}
 	for _, testCase := range testCases {