Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Black, isort, Flake with Ruff #300

Open
hongquan opened this issue Mar 12, 2025 · 5 comments
Open

Replace Black, isort, Flake with Ruff #300

hongquan opened this issue Mar 12, 2025 · 5 comments

Comments

@hongquan
Copy link
Member

Corresponding with fossasia/eventyay-tickets#556
@alikhere
Copy link

Could you please review the PR
Let me know if any changes are needed!

eventyay-tickets-PR

@hongquan
Copy link
Member Author

Note that, this issue is for "eventyay-talk".

@alikhere
Copy link

alikhere commented Mar 15, 2025 •
edited
Loading

Should we replace Black, isort, and Flake with Ruff for both "eventyay-ticket" and "eventyay-talk"? Since issues are created in both repos:

eventyay-ticket (#556)
eventyay-talk (#300)
Or should we proceed with the PR only for eventyay-talk?

@hongquan
Copy link
Member Author

Should we replace Black, isort, and Flake with Ruff for both "eventyay-ticket" and "eventyay-talk"

Yes. But you are posting the link to eventyay-ticket PR in the eventyay-talk issue. It confuses me.

@alikhere
Copy link

alikhere commented Mar 15, 2025 •
edited
Loading

sorry for that.
I will replace Black, isort, and Flake with Ruff both both repo. and make the appropriate changes as mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hongquan @alikhere