Fixed event search box directing to eventyay common event listing #581

suhailnadaf509 · 2025-03-15T11:47:40Z

I've made the following changes to implement the event search functionality that directs to eventyay common instead of eventyay tickets:

Created a new JavaScript file dashboard.js that implements the typeahead search functionality using the eventyay common URLs
Added a new EventSearchView that handles the search API endpoint
Added a URL pattern for the search endpoint
Updated the dashboard template to use our new JavaScript implementation and removed the old typeahead implementation

Closes #516

Summary by Sourcery

New Features:

Adds an event search functionality to the dashboard.

This reverts commit c07fc5a.

sourcery-ai · 2025-03-15T11:47:44Z

Reviewer's Guide by Sourcery

This pull request implements the event search functionality using eventyay common URLs and fixes an issue related to assigning position secrets. The event search is implemented using a typeahead search bar and a new API endpoint. The position secret fix ensures that secrets are unique within an event.

Updated class diagram for EventSearchView

classDiagram
    class EventSearchView {
        +get(request)
    }

    class APIView {
    }

    EventSearchView --|> APIView
    EventSearchView : -query
    EventSearchView : -events
    EventSearchView : -results
    EventSearchView : +JsonResponse results

    note for EventSearchView "Handles the search API endpoint"

File-Level Changes

Change	Details	Files
Implements event search functionality using a typeahead search bar.	Introduced a new JavaScript file to handle the typeahead search functionality. Added a new API endpoint to handle search queries. Updated the dashboard template to integrate the new JavaScript implementation and removed the old implementation.	`src/pretix/eventyay_common/templates/eventyay_common/dashboard/dashboard.html` `src/pretix/eventyay_common/views/event.py` `src/pretix/eventyay_common/urls.py` `src/pretix/eventyay_common/static/eventyay-common/js/ui/dashboard.js`
Fixes an issue where position secrets could be assigned incorrectly.	Modified the query to check for existing position secrets to ensure they are unique within the event, not just the organizer.	`src/pretix/base/orderimport.py`

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#516	The event search box on eventyay-common should direct to event listings on eventyay common, not eventyay tickets.	✅

Possibly linked issues

Eventyay Common: Event search box should direct to eventyay common event listing #516: The PR fixes the issue by implementing the event search functionality and redirecting to the correct eventyay common listing page.

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!
Generate a plan of action for an issue: Comment @sourcery-ai plan on
an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey @suhailnadaf509 - I've reviewed your changes - here's some feedback:

Overall Comments:

Consider adding a debounce to the search input to reduce the number of API calls.
The JavaScript code should be placed in a separate file and properly linked in the template.

Here's what I looked at during the review

🟡 General issues: 2 issues found
🟢 Security: all looks good
🟢 Testing: all looks good
🟡 Complexity: 1 issue found
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

src/pretix/eventyay_common/views/event.py

src/pretix/eventyay_common/static/eventyay-common/js/ui/dashboard.js

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

…ard.js Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

…ay-tickets into issuefix-2

Sak1012 · 2025-04-26T08:26:24Z

src/pretix/base/orderimport.py

@@ -542,7 +542,7 @@ def __init__(self, *args):
        super().__init__(*args)

    def clean(self, value, previous_values):
-        if value and (value in self._cached or OrderPosition.all.filter(order__event__organizer=self.event.organizer, secret=value).exists()):
+                if value and (value in self._cached or OrderPosition.all.filter(order__event__organizer=self.event.organizer, secret=value).exists()):
            raise ValidationError(


The docker build fails due to an Indentation Error here, please fix that

@suhailnadaf509 I fixed the indentation, please check whether the rest of the function is correctly indented.

Noted, thanks for the fix!

mariobehling · 2025-04-28T15:40:18Z

Please help to get Docker working.

src/pretix/eventyay_common/templates/eventyay_common/dashboard/dashboard.html

modified dashboard

norbusan

LGTM

suhailnadaf509 added 4 commits March 14, 2025 20:57

different events can now have the same ticket id

13c5b56

Fixes issue fossasia#516

c07fc5a

Revert "Fixes issue fossasia#516"

2a732a0

This reverts commit c07fc5a.

fixed issue fossasia#516

42793d8

suhailnadaf509 changed the title ~~Implemented the event search functionality . Fixes issue #516516~~ Implemented the event search functionality . Fixes issue #516 Mar 15, 2025

sourcery-ai bot reviewed Mar 15, 2025

View reviewed changes

src/pretix/eventyay_common/views/event.py Outdated Show resolved Hide resolved

src/pretix/eventyay_common/static/eventyay-common/js/ui/dashboard.js Outdated Show resolved Hide resolved

src/pretix/eventyay_common/static/eventyay-common/js/ui/dashboard.js Show resolved Hide resolved

suhailnadaf509 and others added 5 commits March 15, 2025 17:24

updated

ce9d30c

Update src/pretix/eventyay_common/views/event.py

b34af60

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

Update src/pretix/eventyay_common/static/eventyay-common/js/ui/dashbo…

c8d0012

…ard.js Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

updated dashboard.js

54807b1

Merge branch 'issuefix-2' of https://github.com/suhailnadaf509/eventy…

038c45f

…ay-tickets into issuefix-2

suhailnadaf509 changed the title ~~Implemented the event search functionality . Fixes issue #516~~ Implemented the event search functionality . Mar 30, 2025

Merge branch 'development' into issuefix-2

9a6ad8e

suhailnadaf509 changed the title ~~Implemented the event search functionality .~~ Implemented the event search functionality Apr 24, 2025

mariobehling requested a review from norbusan April 24, 2025 16:05

Merge branch 'development' into issuefix-2

84d66c8

Sak1012 reviewed Apr 26, 2025

View reviewed changes

Merge branch 'development' into issuefix-2

f2e064f

Fix indentation errors

0b84733

norbusan requested changes Apr 28, 2025

View reviewed changes

src/pretix/eventyay_common/templates/eventyay_common/dashboard/dashboard.html Outdated Show resolved Hide resolved

mariobehling and others added 4 commits April 29, 2025 15:59

Merge branch 'development' into issuefix-2

eeb9ef8

Update dashboard.html

1d5e50a

modified dashboard

Merge branch 'development' into issuefix-2

9cc3f22

Merge branch 'development' into issuefix-2

fa8b705

mariobehling changed the title ~~Implemented the event search functionality~~ Fixed event search box directing to eventyay common event listing May 16, 2025

mariobehling requested a review from hongquan May 16, 2025 04:57

norbusan approved these changes May 16, 2025

View reviewed changes

mariobehling merged commit 1ed9eb2 into fossasia:development May 16, 2025
1 of 5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixed event search box directing to eventyay common event listing #581

Fixed event search box directing to eventyay common event listing #581

Uh oh!

suhailnadaf509 commented Mar 15, 2025 •

edited by sourcery-ai bot

Loading

Uh oh!

sourcery-ai bot commented Mar 15, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Sak1012 Apr 26, 2025

Uh oh!

norbusan Apr 28, 2025

Uh oh!

suhailnadaf509 May 1, 2025

Uh oh!

mariobehling commented Apr 28, 2025

Uh oh!

Uh oh!

norbusan left a comment

Uh oh!

Uh oh!

Uh oh!

Fixed event search box directing to eventyay common event listing #581

Fixed event search box directing to eventyay common event listing #581

Uh oh!

Conversation

suhailnadaf509 commented Mar 15, 2025 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Sourcery

Uh oh!

sourcery-ai bot commented Mar 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide by Sourcery

Updated class diagram for EventSearchView

File-Level Changes

Assessment against linked issues

Possibly linked issues

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Sak1012 Apr 26, 2025

Choose a reason for hiding this comment

Uh oh!

norbusan Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

suhailnadaf509 May 1, 2025

Choose a reason for hiding this comment

Uh oh!

mariobehling commented Apr 28, 2025

Uh oh!

Uh oh!

norbusan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

suhailnadaf509 commented Mar 15, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Mar 15, 2025 •

edited

Loading