Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented the event search functionality . Fixes issue #516 #581

Open
wants to merge 9 commits into
base: development
Choose a base branch
from

Conversation

suhailnadaf509
Copy link

@suhailnadaf509 suhailnadaf509 commented Mar 15, 2025

I've made the following changes to implement the event search functionality that directs to eventyay common instead of eventyay tickets:

  1. Created a new JavaScript file dashboard.js that implements the typeahead search functionality using the eventyay common URLs
  2. Added a new EventSearchView that handles the search API endpoint
  3. Added a URL pattern for the search endpoint
  4. Updated the dashboard template to use our new JavaScript implementation and removed the old typeahead implementation

Closes #516

Summary by Sourcery

New Features:

  • Adds an event search functionality to the dashboard.

Copy link
Contributor

sourcery-ai bot commented Mar 15, 2025

Reviewer's Guide by Sourcery

This pull request implements the event search functionality using eventyay common URLs and fixes an issue related to assigning position secrets. The event search is implemented using a typeahead search bar and a new API endpoint. The position secret fix ensures that secrets are unique within an event.

Updated class diagram for EventSearchView

Loading
classDiagram
    class EventSearchView {
        +get(request)
    }

    class APIView {
    }

    EventSearchView --|> APIView
    EventSearchView : -query
    EventSearchView : -events
    EventSearchView : -results
    EventSearchView : +JsonResponse results

    note for EventSearchView "Handles the search API endpoint"

File-Level Changes

Change Details Files
Implements event search functionality using a typeahead search bar.
  • Introduced a new JavaScript file to handle the typeahead search functionality.
  • Added a new API endpoint to handle search queries.
  • Updated the dashboard template to integrate the new JavaScript implementation and removed the old implementation.
src/pretix/eventyay_common/templates/eventyay_common/dashboard/dashboard.html
src/pretix/eventyay_common/views/event.py
src/pretix/eventyay_common/urls.py
src/pretix/eventyay_common/static/eventyay-common/js/ui/dashboard.js
Fixes an issue where position secrets could be assigned incorrectly.
  • Modified the query to check for existing position secrets to ensure they are unique within the event, not just the organizer.
src/pretix/base/orderimport.py

Assessment against linked issues

Issue Objective Addressed Explanation
#516 The event search box on eventyay-common should direct to event listings on eventyay common, not eventyay tickets.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@suhailnadaf509 suhailnadaf509 changed the title Implemented the event search functionality . Fixes issue #516516 Implemented the event search functionality . Fixes issue #516 Mar 15, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @suhailnadaf509 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a debounce to the search input to reduce the number of API calls.
  • The JavaScript code should be placed in a separate file and properly linked in the template.
Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

display: "name",
source: eventSearch,
templates: {
suggestion: function (data) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (complexity): Consider using ES6 template literals to simplify the HTML construction and improve readability of the code.

Consider using ES6 template literals to simplify the HTML construction. For example, replace:

return (
  '<div><a href="/common/event/' +
  data.organizer +
  "/" +
  data.slug +
  '/">' +
  data.name +
  "</a></div>"
);

with:

return `<div><a href="/common/event/${data.organizer}/${data.slug}/">${data.name}</a></div>`;

This refactoring reduces complexity and improves readability while preserving all functionality.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the dashboard.js file to use the ES6 template

suhailnadaf509 and others added 5 commits March 15, 2025 17:24
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
…ard.js

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eventyay Common: Event search box should direct to eventyay common event listing
1 participant