Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu link selectors should use the child combinator (.menu a vs .menu > li > a) #12585

Open
thomasfrobieter opened this issue Sep 14, 2023 · 0 comments

Comments

@thomasfrobieter
Copy link

thomasfrobieter commented Sep 14, 2023

What should happen?

None Menu links inside a Foundation Menu component should not receive styles for menu links.
Bad for megamenus, bad for buttons, no benefits?
...

What happens instead?

Well.. menu links inside a Foundation Menu component receive styles for menu links.
...

Possible Solution

.menu > li > a

instead

.menu a

Its very easy to apply menu padding to further links if required, while its sort of impossible to undo them.
We used this fix for years now, no problems. This is the only reason we need to fork the whole repo :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant