feat(traces): add a -d | --depth flag for verbose traces, like tree #12643
+25
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tskoyo
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
grandizzy
requested changes
Nov 25, 2025
Collaborator
grandizzy
left a comment
grandizzy
left a comment
There was a problem hiding this comment.
thank you! left some comments, please check
crates/evm/traces/src/lib.rs
Outdated
| pub fn prune_trace_depth(arena: &mut CallTraceArena, depth: usize) { | ||
| for node in arena.nodes_mut() { | ||
| if node.trace.depth >= depth { | ||
| Vec::clear(&mut node.ordering); |
Collaborator
There was a problem hiding this comment.
nit: can be node.ordering.clear();
crates/forge/src/cmd/test/mod.rs
Outdated
|
|
||
| /// Defines the depth of a trace | ||
| #[arg(long, short)] | ||
| depth: Option<usize>, |
Collaborator
There was a problem hiding this comment.
I think trace_depth would be better naming
Also the ticket mentions cast as well, so let's extend the option to cast too.
| } | ||
|
|
||
| #[test] | ||
| fn depth_trace() { |
Collaborator
There was a problem hiding this comment.
please apply the new option in similar test as with test_trace test here
foundry/crates/forge/tests/cli/test_cmd/trace.rs
Lines 199 to 210 in 6063717
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solve this issue.
This PR introduces a new
--depth(or-d) CLI option toforge testthat allows users to limit how many levels of the call tree are displayed. This change makes traces easier to read.Solution
Example:
Debugging passing tests
Trace output:
a) Command example:
forge test --depth 3 -vvvvTrace output:
b) Command example:
forge test --depth 1 -vvvvDebugging failing tests
Trace output:
a) Command example
forge test --depth 1 -vvvTrace output:
b) Command example:
forge test --depth 3 -vvvPR Checklist