Strip trailing dir separator for translated file paths in ITunesLoader (#952)

Fixes #947

Author: Poeloe

dissect/target/loaders/itunes.py

@@ -290,7 +290,7 @@ def translate_file_path(domain: str, relative_path: str) -> str:
         package_name = ""
 
     domain_path = fsutil.join(DOMAIN_TRANSLATION.get(domain, domain), package_name)
-    return fsutil.join(domain_path, relative_path)
+    return fsutil.join(domain_path, relative_path).rstrip("/")
 
 
 def parse_key_bag(buf: bytes) -> tuple[dict[str, bytes, int], dict[str, ClassKey]]:

tests/loaders/test_itunes.py

@@ -0,0 +1,25 @@
+import pytest
+
+from dissect.target.loaders.itunes import translate_file_path
+
+
+@pytest.mark.parametrize(
+    "domain, relative_path, result",
+    [
+        pytest.param(
+            "HomeDomain",
+            "Library/Safari/SafariTabs.db",
+            "/private/var/mobile/Library/Safari/SafariTabs.db",
+            id="HomeDomain",
+        ),
+        pytest.param("ProtectedDomain", "", "ProtectedDomain", id="ProtectedDomain"),
+        pytest.param(
+            "AppDomain-com.apple.freeform",
+            "",
+            "/private/var/mobile/Containers/Data/Application/com.apple.freeform",
+            id="AppDomain",
+        ),
+    ],
+)
+def test_translate_file_path(domain: str, relative_path: str, result: str) -> None:
+    assert translate_file_path(domain, relative_path) == result