Citrix history plugin collects all files but only parses Citrix specific logs

[Schamper]

dissect.target/dissect/target/plugins/os/unix/bsd/citrix/history.py

Line 73 in 6602b9a

history_files.extend(super()._find_history_files())

It explicitly collects other files as well (bash and zsh etc)

dissect.target/dissect/target/plugins/os/unix/bsd/citrix/history.py

Lines 92 to 96 in 6602b9a

	for shell, history_path, user in self._history_files:
	if shell == "citrix-netscaler-cli":
	yield from self.parse_netscaler_cli_history(history_path, user)
	elif shell in ("citrix-netscaler-bash", "citrix-netscaler-sh"):
	yield from self.parse_netscaler_bash_history(history_path)

But it only parses the Citrix specific ones.

I'm not sure what the impact of this is, do the other files generally exist on Citrix?

@JSCU-CNI I believe you worked most recently on this, can you give any insights?

[JSCU-CNI]

The ESXiPlugin currently has no users implementation so the impact is probably limited

Edit: Working with multiple GitHub topics in parallel can cause side effects apparently, disregard the above comment.

[Schamper]

This is about Citrix, not ESXi, I don't see how that's relevant?

[JSCU-CNI]

#1501 Should fix this bug. I've taken a look at some recent Citrix images, it turns out these history files exist in parallel with the Citrix specific ones.