fix: Stop signals and loops on disconnect (#530)

Fixes #511

Author: elementbound

addons/netfox.extras/plugin.cfg

@@ -3,5 +3,5 @@
 name="netfox.extras"
 description="Game-specific utilities for Netfox"
 author="Tamas Galffy and contributors"
-version="1.35.0"
+version="1.35.1"
 script="netfox-extras.gd"

addons/netfox.internals/plugin.cfg

@@ -3,5 +3,5 @@
 name="netfox.internals"
 description="Shared internals for netfox addons"
 author="Tamas Galffy and contributors"
-version="1.35.0"
+version="1.35.1"
 script="plugin.gd"

addons/netfox.noray/plugin.cfg

@@ -3,5 +3,5 @@
 name="netfox.noray"
 description="Bulletproof your connectivity with noray integration for netfox"
 author="Tamas Galffy and contributors"
-version="1.35.0"
+version="1.35.1"
 script="netfox-noray.gd"

addons/netfox/network-time-synchronizer.gd

@@ -162,14 +162,17 @@ func _loop() -> void:
 	on_initial_sync.emit()
 
 	while _active:
+		if multiplayer.is_server():
+			return stop()
+
 		var sample := NetworkClockSample.new()
 		_awaiting_samples[_sample_idx] = sample
-		
+
 		sample.ping_sent = _clock.get_time()
 		_send_ping.rpc_id(1, _sample_idx)
-		
+
 		_sample_idx += 1
-		
+
 		await get_tree().create_timer(sync_interval).timeout
 
 func _discipline_clock() -> void:

addons/netfox/network-time.gd

@@ -447,7 +447,7 @@ func start() -> int:
 		_initial_sync_done = true
 
 	# Remove clients from the synced cache when disconnected
-	multiplayer.peer_disconnected.connect(func(peer): _synced_peers.erase(peer))
+	multiplayer.peer_disconnected.connect(_handle_peer_disconnect)
 
 	# Set initial clock state
 	_clock.set_time(NetworkTimeSynchronizer.get_time())
@@ -470,6 +470,9 @@ func stop() -> void:
 	_state = _STATE_INACTIVE
 	_synced_peers.clear()
 
+	if multiplayer.peer_disconnected.is_connected(_handle_peer_disconnect):
+		multiplayer.peer_disconnected.disconnect(_handle_peer_disconnect)
+
 ## Check if the initial time sync is done.
 func is_initial_sync_done() -> bool:
 	return _initial_sync_done
@@ -583,6 +586,9 @@ func _notification(what) -> void:
 func _is_active() -> bool:
 	return _state == _STATE_ACTIVE
 
+func _handle_peer_disconnect(peer: int) -> void:
+	_synced_peers.erase(peer)
+
 @rpc("any_peer", "reliable", "call_local")
 func _submit_sync_success() -> void:
 	var peer_id := multiplayer.get_remote_sender_id()

addons/netfox/plugin.cfg

@@ -3,5 +3,5 @@
 name="netfox"
 description="Shared internals for netfox addons"
 author="Tamas Galffy and contributors"
-version="1.35.0"
+version="1.35.1"
 script="netfox.gd"

addons/netfox/time/network-tickrate-handshake.gd

@@ -54,7 +54,7 @@ func run() -> void:
 ## [br][br]
 ## Called by [_NetworkTime], no need to call manually.
 func stop() -> void:
-	if multiplayer.is_server():
+	if multiplayer.peer_connected.is_connected(_handle_new_peer):
 		multiplayer.peer_connected.disconnect(_handle_new_peer)
 
 func _ready() -> void: