chore: Cache project settings (#442)

Closes #304

---------

Co-authored-by: Tamás Gálffy <[email protected]>

Author: gk98s

addons/netfox.extras/plugin.cfg

@@ -3,5 +3,5 @@
 name="netfox.extras"
 description="Game-specific utilities for Netfox"
 author="Tamas Galffy and contributors"
-version="1.25.4"
+version="1.25.5"
 script="netfox-extras.gd"

addons/netfox.extras/window-tiler.gd

@@ -1,7 +1,12 @@
 extends Node
 
+# Settings
+var _is_enabled: bool = ProjectSettings.get_setting(&"netfox/extras/auto_tile_windows", false)
+var _is_borderless: bool = ProjectSettings.get_setting(&"netfox/extras/borderless", false)
+var _tile_screen: int = ProjectSettings.get_setting(&"netfox/extras/screen", 0)
+
 # Hash the game name, so we always get a valid filename
-var _prefix: String = "netfox-window-tiler-%x" % [ProjectSettings.get("application/config/name").hash()]
+var _prefix: String = "netfox-window-tiler-%x" % [ProjectSettings.get_setting(&"application/config/name").hash()]
 
 var _sid: String = "%x" % [hash(int(Time.get_unix_time_from_system() / 2.))]
 var _uid: String = "%d" % [Time.get_unix_time_from_system() * 1000_0000.]
@@ -25,7 +30,7 @@ func _ready() -> void:
 		return
 
 	# Don't tile if disabled
-	if not ProjectSettings.get_setting("netfox/extras/auto_tile_windows", false):
+	if not _is_enabled:
 		return
 
 	_logger.debug("Tiling with sid: %s, uid: %s", [_sid, _uid])
@@ -96,7 +101,7 @@ func _get_uid(filename: String) -> String:
 	return filename.substr(_prefix.length() + 1).get_slice("-", 1)
 
 func _tile_window(i: int, total: int) -> void:
-	var screen = ProjectSettings.get_setting("netfox/extras/screen", 0)
+	var screen = _tile_screen
 	var screen_rect = DisplayServer.screen_get_usable_rect(screen)
 
 	var window: Window = get_tree().get_root()
@@ -106,7 +111,7 @@ func _tile_window(i: int, total: int) -> void:
 		DisplayServer.window_set_mode(DisplayServer.WINDOW_MODE_MAXIMIZED)
 		return
 
-	window.borderless = ProjectSettings.get_setting("netfox/extras/borderless", false)
+	window.borderless = _is_borderless
 
 	# Divide up the screen
 	var windows_per_row = int(ceil(sqrt(total)))

addons/netfox.internals/logger.gd

@@ -79,11 +79,11 @@ static func free_tag(tag: Callable) -> void:
 	_ordered_tags.erase(tag)
 
 static func _static_init():
-	log_level = ProjectSettings.get_setting("netfox/logging/log_level", DEFAULT_LOG_LEVEL)
+	log_level = ProjectSettings.get_setting(&"netfox/logging/log_level", DEFAULT_LOG_LEVEL)
 	module_log_level = {
-		"netfox": ProjectSettings.get_setting("netfox/logging/netfox_log_level", DEFAULT_LOG_LEVEL),
-		"netfox.noray": ProjectSettings.get_setting("netfox/logging/netfox_noray_log_level", DEFAULT_LOG_LEVEL),
-		"netfox.extras": ProjectSettings.get_setting("netfox/logging/netfox_extras_log_level", DEFAULT_LOG_LEVEL)
+		"netfox": ProjectSettings.get_setting(&"netfox/logging/netfox_log_level", DEFAULT_LOG_LEVEL),
+		"netfox.noray": ProjectSettings.get_setting(&"netfox/logging/netfox_noray_log_level", DEFAULT_LOG_LEVEL),
+		"netfox.extras": ProjectSettings.get_setting(&"netfox/logging/netfox_extras_log_level", DEFAULT_LOG_LEVEL)
 	}
 
 func _init(p_module: String, p_name: String):

addons/netfox.internals/plugin.cfg

@@ -3,5 +3,5 @@
 name="netfox.internals"
 description="Shared internals for netfox addons"
 author="Tamas Galffy and contributors"
-version="1.25.4"
+version="1.25.5"
 script="plugin.gd"

addons/netfox.noray/plugin.cfg

@@ -3,5 +3,5 @@
 name="netfox.noray"
 description="Bulletproof your connectivity with noray integration for netfox"
 author="Tamas Galffy and contributors"
-version="1.25.4"
+version="1.25.5"
 script="netfox-noray.gd"

addons/netfox/network-time-synchronizer.gd

@@ -20,7 +20,7 @@ const MIN_SYNC_INTERVAL := 0.1
 var sync_interval: float:
 	get:
 		return maxf(
-			ProjectSettings.get_setting(&"netfox/time/sync_interval", 0.25),
+			_sync_interval,
 			MIN_SYNC_INTERVAL
 		)
 	set(v):
@@ -31,7 +31,7 @@ var sync_interval: float:
 ## [i]read-only[/i], you can change this in the Netfox project settings
 var sync_samples: int:
 	get:
-		return ProjectSettings.get_setting(&"netfox/time/sync_samples", 8)
+		return _sync_samples
 	set(v):
 		push_error("Trying to set read-only variable sync_samples")
 
@@ -44,7 +44,7 @@ var sync_samples: int:
 ## [i]read-only[/i], you can change this in the Netfox project settings
 var adjust_steps: int:
 	get:
-		return ProjectSettings.get_setting(&"netfox/time/sync_adjust_steps", 8)
+		return _adjust_steps
 	set(v):
 		push_error("Trying to set read-only variable adjust_steps")
 
@@ -56,7 +56,7 @@ var adjust_steps: int:
 ## [i]read-only[/i], you can change this in the Netfox project settings
 var panic_threshold: float:
 	get:
-		return ProjectSettings.get_setting(&"netfox/time/recalibrate_threshold", 2.)
+		return _panic_threshold
 	set(v):
 		push_error("Trying to set read-only variable panic_threshold")
 
@@ -95,6 +95,12 @@ var remote_offset: float:
 		return _offset
 	set(v):
 		push_error("Trying to set read-only variable remote_offset")
+		
+# Settings
+var _sync_interval: float = ProjectSettings.get_setting(&"netfox/time/sync_interval", 0.25)
+var _sync_samples: int = ProjectSettings.get_setting(&"netfox/time/sync_samples", 8)
+var _adjust_steps: int =ProjectSettings.get_setting(&"netfox/time/sync_adjust_steps", 8)
+var _panic_threshold: float = ProjectSettings.get_setting(&"netfox/time/recalibrate_threshold", 2.)
 
 var _active: bool = false
 static var _logger: _NetfoxLogger = _NetfoxLogger.for_netfox("NetworkTimeSynchronizer")

addons/netfox/network-time.gd

@@ -13,7 +13,7 @@ var tickrate: int:
 		if sync_to_physics:
 			return Engine.physics_ticks_per_second
 		else:
-			return ProjectSettings.get_setting(&"netfox/time/tickrate", 30)
+			return _tickrate
 	set(v):
 		push_error("Trying to set read-only variable tickrate")
 
@@ -25,7 +25,7 @@ var tickrate: int:
 ## [i]read-only[/i], you can change this in the project settings
 var sync_to_physics: bool:
 	get:
-		return ProjectSettings.get_setting(&"netfox/time/sync_to_physics", false)
+		return _sync_to_physics
 	set(v):
 		push_error("Trying to set read-only variable sync_to_physics")
 
@@ -40,7 +40,7 @@ var sync_to_physics: bool:
 ## [i]read-only[/i], you can change this in the project settings
 var max_ticks_per_frame: int:
 	get:
-		return ProjectSettings.get_setting(&"netfox/time/max_ticks_per_frame", 8)
+		return _max_ticks_per_frame
 	set(v):
 		push_error("Trying to set read-only variable max_ticks_per_frame")
 
@@ -100,7 +100,7 @@ var tick: int:
 ## @deprecated: Use [member _NetworkTimeSynchronizer.panic_threshold] instead.
 var recalibrate_threshold: float:
 	get:
-		return ProjectSettings.get_setting(&"netfox/time/recalibrate_threshold", 8.0)
+		return _recalibrate_threshold
 	set(v):
 		push_error("Trying to set read-only variable recalibrate_threshold")
 
@@ -113,7 +113,7 @@ var recalibrate_threshold: float:
 ## against.
 var stall_threshold: float:
 	get:
-		return ProjectSettings.get_setting(&"netfox/time/stall_threshold", 1.0)
+		return _stall_threshold
 	set(v):
 		push_error("Trying to set read-only variable stall_threshold")
 
@@ -266,15 +266,15 @@ var physics_factor: float:
 ## [i]read-only[/i], you can change this in the project settings
 var clock_stretch_max: float:
 	get:
-		return ProjectSettings.get_setting(&"netfox/time/max_time_stretch", 1.25)
+		return _clock_stretch_max
 	set(v):
 		push_error("Trying to set read-only variable stretch_max")
 
 ## Suppress warning when calling [member start] with an [OfflineMultiplayerPeer]
 ## active.
 var suppress_offline_peer_warning: bool:
 	get:
-		return ProjectSettings.get_setting(&"netfox/time/suppress_offline_peer_warning", false)
+		return _suppress_offline_peer_warning
 	set(v):
 		push_error("Trying to set read-only variable suppress_offline_peer_warning")
 
@@ -364,8 +364,18 @@ const _STATE_INACTIVE := 0
 const _STATE_SYNCING := 1
 const _STATE_ACTIVE := 2
 
+# Settings
+var _tickrate: int = ProjectSettings.get_setting(&"netfox/time/tickrate", 30)
+var _sync_to_physics: bool = ProjectSettings.get_setting(&"netfox/time/sync_to_physics", false)
+var _max_ticks_per_frame: int = ProjectSettings.get_setting(&"netfox/time/max_ticks_per_frame", 8)
+var _recalibrate_threshold: float = ProjectSettings.get_setting(&"netfox/time/recalibrate_threshold", 8.0)
+var _stall_threshold: float = ProjectSettings.get_setting(&"netfox/time/stall_threshold", 1.0)
+var _clock_stretch_max: float = ProjectSettings.get_setting(&"netfox/time/max_time_stretch", 1.25)
+var _suppress_offline_peer_warning: bool = ProjectSettings.get_setting(&"netfox/time/suppress_offline_peer_warning", false)
+
 var _state: int = _STATE_INACTIVE
 
+# Timing
 var _tick: int = 0
 var _was_paused: bool = false
 var _initial_sync_done = false

addons/netfox/plugin.cfg

@@ -3,5 +3,5 @@
 name="netfox"
 description="Shared internals for netfox addons"
 author="Tamas Galffy and contributors"
-version="1.25.4"
+version="1.25.5"
 script="netfox.gd"

addons/netfox/rollback/network-rollback.gd

@@ -25,7 +25,7 @@ var enable_diff_states: bool = ProjectSettings.get_setting(&"netfox/rollback/ena
 ## [i]read-only[/i], you can change this in the project settings
 var history_limit: int:
 	get:
-		return ProjectSettings.get_setting(&"netfox/rollback/history_limit", 64)
+		return _history_limit
 	set(v):
 		push_error("Trying to set read-only variable history_limit")
 
@@ -50,7 +50,7 @@ var history_start: int:
 ## [i]read-only[/i], you can change this in the project settings
 var display_offset: int:
 	get:
-		return ProjectSettings.get_setting(&"netfox/rollback/display_offset", 0)
+		return _display_offset
 	set(v):
 		push_error("Trying to set read-only variable display_offset")
 
@@ -85,9 +85,10 @@ var display_tick: int:
 ## with input latency higher than network latency.
 ## [br][br]
 ## [i]read-only[/i], you can change this in the project settings
+
 var input_delay: int:
 	get:
-		return ProjectSettings.get_setting(&"netfox/rollback/input_delay", 0)
+		return _input_delay
 	set(v):
 		push_error("Trying to set read-only variable input_delay")
 
@@ -99,10 +100,10 @@ var input_delay: int:
 ## in transmission, the next (n-1) packets will contain the data for it.
 ## [br][br]
 ## [i]read-only[/i], you can change this in the project settings
+
 var input_redundancy: int:
 	get:
-		var value := ProjectSettings.get_setting(&"netfox/rollback/input_redundancy", 3)
-		return max(1, value)
+		return max(1, _input_redundancy)
 	set(v):
 		push_error("Trying to set read-only variable input_redundancy")
 
@@ -146,17 +147,25 @@ signal on_record_tick(tick: int)
 ## Event emitted after running the network rollback loop
 signal after_loop()
 
+# Settings
+var _history_limit: int = ProjectSettings.get_setting(&"netfox/rollback/history_limit", 64)
+var _display_offset: int = ProjectSettings.get_setting(&"netfox/rollback/display_offset", 0)
+var _input_delay: int = ProjectSettings.get_setting(&"netfox/rollback/input_delay", 0)
+var _input_redundancy: int = ProjectSettings.get_setting(&"netfox/rollback/input_redundancy", 3)
+
+# Timing
 var _tick: int = 0
 var _resim_from: int
 
-var _is_rollback: bool = false
-var _simulated_nodes: Dictionary = {}
-var _mutated_nodes: Dictionary = {}
-
 var _rollback_from: int = -1
 var _rollback_to: int = -1
 var _rollback_stage: String = ""
 
+# Resim + mutations
+var _is_rollback: bool = false
+var _simulated_nodes: Dictionary = {}
+var _mutated_nodes: Dictionary = {}
+
 const _STAGE_BEFORE := "B"
 const _STAGE_PREPARE := "P"
 const _STAGE_SIMULATE := "S"
@@ -198,7 +207,7 @@ func is_rollback() -> bool:
 ## This is used by [RollbackSynchronizer] to see if it should simulate the
 ## given object during rollback.
 func is_rollback_aware(what: Object) -> bool:
-	return what.has_method("_rollback_tick")
+	return what.has_method(&"_rollback_tick")
 
 ## Calls the [code]_rollback_tick[/code] method on the target, running its
 ## simulation for the given rollback tick.

examples/forest-brawl/scripts/brawler-controller.gd

@@ -30,7 +30,7 @@ var player_name: String = "":
 var player_id: int = -1
 var last_hit_player: BrawlerController
 var last_hit_tick: int = -1
-var gravity = ProjectSettings.get_setting("physics/3d/default_gravity")
+var gravity = ProjectSettings.get_setting(&"physics/3d/default_gravity")
 var respawn_tick: int = -1
 var respawn_count: int = 0
 

examples/input-prediction/marble.gd

@@ -10,7 +10,7 @@ var is_reversing := false
 @onready var _rollback_synchronizer := $RollbackSynchronizer as RollbackSynchronizer
 @onready var input := $Input as Node
 
-var gravity: float = ProjectSettings.get_setting("physics/3d/default_gravity")
+var gravity: float = ProjectSettings.get_setting(&"physics/3d/default_gravity")
 
 func _ready():
 	position = Vector3(0, 4, 0)

examples/multiplayer-fps/scripts/player.gd

@@ -11,7 +11,7 @@ extends CharacterBody3D
 
 static var _logger := _NetfoxLogger.new("game", "Player")
 
-var gravity = ProjectSettings.get_setting("physics/3d/default_gravity")
+var gravity = ProjectSettings.get_setting(&"physics/3d/default_gravity")
 var health: int = 100
 var death_tick: int = -1
 var respawn_position: Vector3

examples/multiplayer-fps/scripts/ui/window-size-connector.gd

@@ -29,6 +29,6 @@ func _target_nodes_changed(new_value: Array[Node]):
 		return
 
 	_on_window_resized(Vector2(
-		ProjectSettings.get_setting("display/window/size/viewport_width"),
-		ProjectSettings.get_setting("display/window/size/viewport_height")
+		ProjectSettings.get_setting(&"display/window/size/viewport_width"),
+		ProjectSettings.get_setting(&"display/window/size/viewport_height")
 	))

examples/multiplayer-netfox/scripts/player.gd

@@ -4,7 +4,7 @@ extends CharacterBody3D
 @export var input: PlayerInput
 
 # Get the gravity from the project settings to be synced with RigidBody nodes.
-var gravity = ProjectSettings.get_setting("physics/3d/default_gravity")
+var gravity = ProjectSettings.get_setting(&"physics/3d/default_gravity")
 
 func _ready():
 	position = Vector3(0, 4, 0)

examples/multiplayer-simple/scripts/player.gd

@@ -3,7 +3,7 @@ extends CharacterBody3D
 @export var speed = 5.0
 
 # Get the gravity from the project settings to be synced with RigidBody nodes.
-var gravity = ProjectSettings.get_setting("physics/3d/default_gravity")
+var gravity = ProjectSettings.get_setting(&"physics/3d/default_gravity")
 
 func _physics_process(delta):
 	if not is_multiplayer_authority():

examples/multiplayer-state-machine/scripts/player.gd

@@ -13,7 +13,7 @@ var _color: Color = Color.WHITE
 var _material: StandardMaterial3D = StandardMaterial3D.new()
 
 # Get the gravity from the project settings to be synced with RigidBody nodes.
-var gravity = ProjectSettings.get_setting("physics/3d/default_gravity")
+var gravity = ProjectSettings.get_setting(&"physics/3d/default_gravity")
 
 func _ready():
 	# Set spawn position

examples/rollback-fps/scripts/player.gd

@@ -12,7 +12,7 @@ extends CharacterBody3D
 
 static var _logger := _NetfoxLogger.new("game", "Player")
 
-var gravity = ProjectSettings.get_setting("physics/3d/default_gravity")
+var gravity = ProjectSettings.get_setting(&"physics/3d/default_gravity")
 var health: int = 100
 var death_tick: int = -1
 var respawn_position: Vector3

examples/single-player/scripts/player.gd

@@ -3,7 +3,7 @@ extends CharacterBody3D
 @export var speed = 5.0
 
 # Get the gravity from the project settings to be synced with RigidBody nodes.
-var gravity = ProjectSettings.get_setting("physics/3d/default_gravity")
+var gravity = ProjectSettings.get_setting(&"physics/3d/default_gravity")
 
 func _physics_process(delta):
 	# Add the gravity.