Skip to content

Commit 480ad18

Browse files
authored
fix: Format minutes correctly (#175)
1 parent 2b310e1 commit 480ad18

File tree

4 files changed

+19
-2
lines changed

4 files changed

+19
-2
lines changed

addons/vest/plugin.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
name="vest"
44
description="A unit testing library for Godot"
55
author="Tamás Gálffy and contributors"
6-
version="1.10.3"
6+
version="1.10.4"
77
script="plugin.gd"

addons/vest/ui/vest-ui.gd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ static func get_status_icon(what: Variant) -> Texture2D:
204204

205205
static func format_duration(duration: float) -> String:
206206
if duration > 60.:
207-
return "%.2fmin" % duration
207+
return "%.2fmin" % [duration / 60.]
208208
elif duration > 1.:
209209
return "%.2fs" % duration
210210
elif duration > 0.001:

tests/format-duration.test.gd

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
extends VestTest
2+
3+
func get_suite_name():
4+
return "VestUI.format_duration()"
5+
6+
func suite():
7+
var cases := [
8+
["minutes", 150., "2.50min"],
9+
["seconds", 17.85, "17.85s"],
10+
["milliseconds", 0.758, "758.00ms"],
11+
["microseconds", 0.000_004_520, "4.52µs"],
12+
["rounding", 1.1705, "1.17s"]
13+
]
14+
15+
for case in cases:
16+
test(case[0], func(): expect_equal(VestUI.format_duration(case[1]), case[2]))

tests/format-duration.test.gd.uid

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
uid://d2mq852selen1

0 commit comments

Comments
 (0)