Remove deprecated code (apache#1141)

Author: Fokko

crates/iceberg/src/spec/snapshot.rs

@@ -207,6 +207,7 @@ impl Snapshot {
         )
     }
 
+    #[allow(dead_code)]
     pub(crate) fn log(&self) -> SnapshotLog {
         SnapshotLog {
             timestamp_ms: self.timestamp_ms,

crates/iceberg/src/spec/table_metadata.rs

@@ -33,9 +33,8 @@ use uuid::Uuid;
 use super::snapshot::SnapshotReference;
 pub use super::table_metadata_builder::{TableMetadataBuildResult, TableMetadataBuilder};
 use super::{
-    PartitionSpecRef, PartitionStatisticsFile, SchemaId, SchemaRef, Snapshot, SnapshotRef,
-    SnapshotRetention, SortOrder, SortOrderRef, StatisticsFile, StructType,
-    DEFAULT_PARTITION_SPEC_ID,
+    PartitionSpecRef, PartitionStatisticsFile, SchemaId, SchemaRef, SnapshotRef, SnapshotRetention,
+    SortOrder, SortOrderRef, StatisticsFile, StructType, DEFAULT_PARTITION_SPEC_ID,
 };
 use crate::error::{timestamp_ms_to_utc, Result};
 use crate::{Error, ErrorKind};
@@ -398,33 +397,6 @@ impl TableMetadata {
         self.partition_statistics.get(&snapshot_id)
     }
 
-    /// Append snapshot to table
-    #[deprecated(
-        since = "0.4.0",
-        note = "please use `TableMetadataBuilder.set_branch_snapshot` instead"
-    )]
-    pub fn append_snapshot(&mut self, snapshot: Snapshot) {
-        self.last_updated_ms = snapshot.timestamp_ms();
-        self.last_sequence_number = snapshot.sequence_number();
-
-        self.refs
-            .entry(MAIN_BRANCH.to_string())
-            .and_modify(|s| {
-                s.snapshot_id = snapshot.snapshot_id();
-            })
-            .or_insert_with(|| {
-                SnapshotReference::new(snapshot.snapshot_id(), SnapshotRetention::Branch {
-                    min_snapshots_to_keep: None,
-                    max_snapshot_age_ms: None,
-                    max_ref_age_ms: None,
-                })
-            });
-
-        self.snapshot_log.push(snapshot.log());
-        self.snapshots
-            .insert(snapshot.snapshot_id(), Arc::new(snapshot));
-    }
-
     fn construct_refs(&mut self) {
         if let Some(current_snapshot_id) = self.current_snapshot_id {
             if !self.refs.contains_key(MAIN_BRANCH) {