From 8c454a333ea5a86c288a59fc307a2bf3114c4477 Mon Sep 17 00:00:00 2001 From: Jannat Patel Date: Thu, 19 Sep 2024 14:19:55 +0530 Subject: [PATCH] fix: evaluator name issue --- .../lms_certificate_request/lms_certificate_request.py | 2 ++ lms/patches.txt | 2 +- .../v2_0/delete_certificate_request_notification.py | 8 +++++++- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/lms/lms/doctype/lms_certificate_request/lms_certificate_request.py b/lms/lms/doctype/lms_certificate_request/lms_certificate_request.py index ab88fc085..c172f2dc3 100644 --- a/lms/lms/doctype/lms_certificate_request/lms_certificate_request.py +++ b/lms/lms/doctype/lms_certificate_request/lms_certificate_request.py @@ -13,6 +13,7 @@ get_datetime, nowtime, get_time, + get_fullname, ) from lms.lms.utils import get_evaluator import json @@ -32,6 +33,7 @@ def after_insert(self): def set_evaluator(self): if not self.evaluator: self.evaluator = get_evaluator(self.course, self.batch_name) + self.evaluator_name = get_fullname(self.evaluator) def validate_unavailability(self): if self.evaluator: diff --git a/lms/patches.txt b/lms/patches.txt index 74a76ef96..e03d48f4b 100644 --- a/lms/patches.txt +++ b/lms/patches.txt @@ -90,4 +90,4 @@ lms.patches.v1_0.set_published_on lms.patches.v2_0.fix_progress_percentage lms.patches.v2_0.add_discussion_topic_titles lms.patches.v2_0.sidebar_settings -lms.patches.v2_0.delete_certificate_request_notification \ No newline at end of file +lms.patches.v2_0.delete_certificate_request_notification #18-09-2024 \ No newline at end of file diff --git a/lms/patches/v2_0/delete_certificate_request_notification.py b/lms/patches/v2_0/delete_certificate_request_notification.py index 53b907df3..b7a8ed767 100644 --- a/lms/patches/v2_0/delete_certificate_request_notification.py +++ b/lms/patches/v2_0/delete_certificate_request_notification.py @@ -2,4 +2,10 @@ def execute(): - frappe.db.delete("Notification", "Certificate Request Creation") + delete_notification("Certificate Request Creation") + delete_notification("Certificate Request Reminder") + + +def delete_notification(notification_name): + if frappe.db.exists("Notification", notification_name): + frappe.db.delete("Notification", notification_name)