Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data field type reflects to be as a link field #1273

Closed
sharif-dotcom opened this issue Jan 28, 2025 · 4 comments
Closed

Data field type reflects to be as a link field #1273

sharif-dotcom opened this issue Jan 28, 2025 · 4 comments
Labels
bug Something isn't working

Comments

@sharif-dotcom
Copy link

sharif-dotcom commented Jan 28, 2025

Describe the bug
Found our that on the LMS Settings (payment settings tab )the payment gateway field changes to a link field type on usage

To Reproduce
Steps to reproduce the behavior:

  1. Navigate to the doctype "LMS Setting" (with out doing anything) OR At one end
  2. Go back on setting the payment gateway(from there, it reflects to as a link field)

Expected behavior
Was expecting to set a value for the data field instead that of the linked one

Screenshots
A screenshot of a LMS Setting (doc) showing a field to be (data)
Image

And to what it reflects on setting up the payment gateway on the payment settings tab

Image

Desktop (Device and platforms ):

  • OS: Mac - MacOS
  • Browser: Opera, Chrome
@sharif-dotcom sharif-dotcom added the bug Something isn't working label Jan 28, 2025
@sharif-dotcom
Copy link
Author

I noticed that the issue arises because the payment_gateway field in the Payment Gateway Account DocType in ERPNext conflicts with the same field in LMS Settings. When I changed the field name payment_gateway in the LMS Settings DocType within the LMS app, the issue was resolved.

@sharif-dotcom
Copy link
Author

After changing the field, I noticed that the error 'Payment Gateway could not be found' still appeared, indicating that the system expects it to be a valid entry from the Payment Gateway DocType. This suggests that the field should be a Link field instead of a plain text field.

Given this, what would be the right approach to resolving the issue?

@pateljannat
Copy link
Collaborator

@sharif-dotcom, it seems like you are trying to use DPO as the payment gateway. Frappe Learning has been integrated with the Payments app to handle all payments. And the Payments app by default doesn't support DPO. You will have to contribute this to the app. https://github.com/frappe/payments

@sharif-dotcom
Copy link
Author

@pateljannat, that should be the goooo nowwwww. But then in the LMS Settings, the field for payment gateway, on payment settings tab should visually be a link field because thats what it reflects instead of being a data type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants