Skip to content

Commit 124e733

Browse files
Merge pull request #66 from fredericvl/min_max_water_temp
Support min and max water temperature
2 parents 660d7cf + 588423c commit 124e733

File tree

2 files changed

+24
-10
lines changed

2 files changed

+24
-10
lines changed

py_agua_iot/__init__.py

Lines changed: 23 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -498,17 +498,23 @@ def __get_information_item(self, item, format_string=False):
498498
return None
499499

500500
def __get_information_item_min(self, item):
501-
value = int(self.__register_map_dict[item]["set_min"])
502-
_LOGGER.debug("GET '%s' MIN: %s", item, value)
503-
return value
501+
try:
502+
value = int(self.__register_map_dict[item]["set_min"])
503+
_LOGGER.debug("GET '%s' MIN: %s", item, value)
504+
return value
505+
except (KeyError, ValueError):
506+
return None
504507

505508
def __get_information_item_max(self, item):
506-
value = int(self.__register_map_dict[item]["set_max"])
507-
_LOGGER.debug("GET '%s' MAX: %s", item, value)
508-
return value
509+
try:
510+
value = int(self.__register_map_dict[item]["set_max"])
511+
_LOGGER.debug("GET '%s' MAX: %s", item, value)
512+
return value
513+
except (KeyError, ValueError):
514+
return None
509515

510516
def __prepare_value_for_writing(self, item, value):
511-
value = float(value)
517+
value = int(value)
512518
set_min = self.__register_map_dict[item]["set_min"]
513519
set_max = self.__register_map_dict[item]["set_max"]
514520

@@ -631,11 +637,11 @@ def alarms_translated(self):
631637
]
632638

633639
@property
634-
def min_temp(self):
640+
def min_air_temp(self):
635641
return self.__get_information_item_min("temp_air_set")
636642

637643
@property
638-
def max_temp(self):
644+
def max_air_temp(self):
639645
return self.__get_information_item_max("temp_air_set")
640646

641647
@property
@@ -662,6 +668,14 @@ def set_air_temperature(self, value):
662668
except Error:
663669
raise Error("Error while trying to set temperature")
664670

671+
@property
672+
def min_water_temp(self):
673+
return self.__get_information_item_min("temp_water_set")
674+
675+
@property
676+
def max_water_temp(self):
677+
return self.__get_information_item_max("temp_water_set")
678+
665679
@property
666680
def water_temperature(self):
667681
return self.__get_information_item("temp_water_get")

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
setuptools.setup(
77
name="py-agua-iot",
8-
version="0.0.16",
8+
version="0.0.17",
99
author="Frederic Van Linthoudt",
1010
author_email="[email protected]",
1111
description="py-agua-iot provides controlling heating devices connected via the IOT Agua platform of Micronova",

0 commit comments

Comments
 (0)