Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-requirements needs to recognize two-digit version numbers #38

Open
sssoleileraaa opened this issue May 6, 2019 · 0 comments
Open

Comments

@sssoleileraaa
Copy link
Contributor

Description

When creating the requirements.txt file by running the update-requirements script, two hashes were added to for our urllib dependency when we only expected one.

This is due to a bug in the script that uses startswith command to decide which package to grab -- two different versions of the same package can satisfy the check condition. E.g. urllib3-1.24.1 and urllib3-1.24 both start with urllib3-1.24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant