Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete sources dialogue (when no sources selected) - can't click OK #2290

Closed
deeplow opened this issue Nov 12, 2024 · 1 comment · Fixed by #2291
Closed

Delete sources dialogue (when no sources selected) - can't click OK #2290

deeplow opened this issue Nov 12, 2024 · 1 comment · Fixed by #2291
Milestone

Comments

@deeplow
Copy link
Contributor

deeplow commented Nov 12, 2024

Description

When no sources are selected and the delete sources button is clicked it does show the dialogue, but the "continue" button does nothing. This happens in the client 0.14.0 (currently in release process) (CC @zenmonkeykstop)

Steps to Reproduce

No sources are selected and the user clicks "delete sources" button.

Expected Behavior

Clicking on the CONTINUE dismisses the dialogue

Actual Behavior

The button does nothing:

Comments

Instead of letting the user click "continue", perhaps we could simply disable / grey out the "delete sources" button when no source is selected. This would follow the usability heuristic #5:

5: Error Prevention

Good error messages are important, but the best designs carefully prevent problems from occurring in the first place. Either eliminate error-prone conditions, or check for them and present users with a confirmation option before they commit to the action.

-- https://www.nngroup.com/articles/ten-usability-heuristics/

@zenmonkeykstop
Copy link
Contributor

If you click the Delete Sources button on startup, before any source has been selected, nothing happens at all. It's another inconsistency but more in line with the suggested behavior above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants